feat(vue): drop vue 2 support and allow dynamic Store instance #179
Closed
teleskop150750 wants to merge 2 commits intoTanStack:mainfrom
Closed
feat(vue): drop vue 2 support and allow dynamic Store instance #179teleskop150750 wants to merge 2 commits intoTanStack:mainfrom
teleskop150750 wants to merge 2 commits intoTanStack:mainfrom
Conversation
Member
|
Please provide a description of what you're doing and why, alongside rationale for your changes. Closing until then. |
Author
|
@crutchcorn Added description |
Author
|
@crutchcorn Hi, can you open this PR? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
shallowfunctionforreplaced withfor-ofDrop Vue 2 support, optimize bundles and clean up
Use
shallowRefThere is no point in using
refwith deep reactivity because the entire object is replaced.An alternative might be to create a solidjs
reconcileanalogue forvueLink
Use
MaybeRefOrGetterto be able to pass reactive variables
Required for tantack db to work
TanStack/db#85
Instead of watchEffect you can use computed, but this will change the type of the returned result
Example