Skip to content

fix(solid-query): allow optional initialData in infiniteQueryOptions #11291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thribhuvan003 wants to merge 1 commit into
base: main
Choose a base branch
from
+28 −1
Open

fix(solid-query): allow optional initialData in infiniteQueryOptions #11291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/olive-pugs-repeat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/solid-query': patch
---

Allow optional `initialData` in `infiniteQueryOptions`, matching react-query
19 changes: 19 additions & 0 deletions packages/solid-query/src/__tests__/infiniteQueryOptions.test-d.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,4 +136,23 @@ describe('infiniteQueryOptions', () => {
}>
>()
})

it('should allow optional initialData object', () => {
const initialData = { wow: true } as { wow: boolean } | undefined
const options = infiniteQueryOptions({
queryKey: queryKey(),
queryFn: () => initialData,
initialData: initialData
? { pages: [initialData], pageParams: [] }
: undefined,
getNextPageParam: () => 1,
initialPageParam: 1,
})

expectTypeOf(options.initialData).toExtend<
| InfiniteData<{ wow: boolean } | undefined, number>
| (() => InfiniteData<{ wow: boolean } | undefined, number>)
| undefined
>()
})
})
5 changes: 4 additions & 1 deletion packages/solid-query/src/infiniteQueryOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ export type UndefinedInitialDataInfiniteOptions<
TPageParam = unknown,
> = Accessor<
InfiniteQueryOptions<TQueryFnData, TError, TData, TQueryKey, TPageParam> & {
initialData?: undefined
initialData?:
| undefined
| NonUndefinedGuard<InfiniteData<TQueryFnData, TPageParam>>
| (() => NonUndefinedGuard<InfiniteData<TQueryFnData, TPageParam>>)
}
>

Expand Down