Skip to content

Detect release revisions after squash merges - #139

Merged
tannerlinsley merged 1 commit into
mainfrom
taren/fix-squashed-release-revision
Sep 8, 2026
Merged

Detect release revisions after squash merges#139
tannerlinsley merged 1 commit into
mainfrom
taren/fix-squashed-release-revision

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Sep 8, 2026

Copy link
Copy Markdown
Member

The 0.16.1 publish stopped before uploading packages because release discovery only recognized merge-commit subjects containing changeset-release/main. The version PR was squash-merged, so its valid version bump was invisible to that check.

Find the commit that introduced the requested version along first-parent history instead. This supports merge, squash, and rebased histories and skips later manifest edits that keep the same version. The current repository correctly resolves 0.16.1 to 7117aca3babe7fe07aabf1fa64b1a18617e60097.

Regression tests cover all three histories, subsequent manifest edits, and a missing version. This changes release tooling only and resumes the existing 0.16.1 release without another changeset.

Summary by CodeRabbit

  • Bug Fixes
    • Release status detection now reliably identifies the commit where a version is introduced across merge, squash, and rebase workflows.
    • Improved error messaging when a requested release revision cannot be found.
  • Tests
    • Expanded coverage for multiple release integration methods.
    • Added validation for unknown release versions.

@nx-cloud

nx-cloud Bot commented Sep 8, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit f4e2731

Command Status Duration Result
nx run charts-workspace:ci-distributed ✅ Succeeded 56s View ↗
nx run charts-workspace:package-check ✅ Succeeded <1s View ↗
nx run charts-workspace:benchmark-check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-09-08 22:41:34 UTC

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: a9eb2885-6787-41f8-adac-ada531c6834d

📥 Commits

Reviewing files that changed from the base of the PR and between 7117aca and f4e2731.

📒 Files selected for processing (2)
  • scripts/release-status.mjs
  • scripts/release-status.test.mjs

📝 Walkthrough

Walkthrough

The release script now finds the first-parent commit that introduces a target manifest version. Tests cover merge, squash, and rebase histories and verify the unknown-version error.

Changes

Release revision detection

Layer / File(s) Summary
Version-introduction lookup and coverage
scripts/release-status.mjs, scripts/release-status.test.mjs
readReleaseRevision now compares each commit's manifest version with its parent's version while walking first-parent history. Tests cover merge, squash, and rebase strategies and an unknown version.

Estimated code review effort: 2 (Simple) | ~10 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch taren/fix-squashed-release-revision

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tannerlinsley
tannerlinsley merged commit a100372 into main Sep 8, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant