-
Notifications
You must be signed in to change notification settings - Fork 51
chore(QTDI-2158):Use jakartaee/jaxb-api to replace jaxb in javax.xml.bind #1136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...rc/test/java/org/talend/sdk/component/runtime/manager/service/HttpClientFactoryImplTest.java
Outdated
Show resolved
Hide resolved
undx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments to check
component-runtime-manager/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.glassfish.jaxb</groupId> | ||
| <artifactId>jaxb-runtime</artifactId> | ||
| <version>${jakarta.version}</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in master pom's dependencyManagement section, should not be necessary.
Also, is glassfish's jaxb in sync with jakarta?
| <dependency> | ||
| <groupId>jakarta.xml.bind</groupId> | ||
| <artifactId>jakarta.xml.bind-api</artifactId> | ||
| <version>${jakarta.version}</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in master pom's dependencyManagement section, should not be necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jakarta.xml.bind is NOT in master pom's dependencyManagement section
Removed version placeholder for jaxb-runtime dependency.
undx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm

Requirements
Why this PR is needed?
What does this PR adds (design/code thoughts)?