Skip to content

Allow newer brick/math versions#13

Open
tacman wants to merge 1 commit into
TRowbotham:masterfrom
tacman:codex/allow-brick-math-017
Open

Allow newer brick/math versions#13
tacman wants to merge 1 commit into
TRowbotham:masterfrom
tacman:codex/allow-brick-math-017

Conversation

@tacman
Copy link
Copy Markdown

@tacman tacman commented May 22, 2026

This widens the brick/math constraint to allow currently released 0.x versions through 0.17.

rowbot/url uses brick/math through BrickMathAdapter for integer host parsing operations. The adapter uses BigInteger construction, comparison, division, modulo, multiplication, addition, and power operations, and does not appear to rely on the APIs affected by newer brick/math breaking changes such as BigDecimal, BigRational, float inputs, or exception constructors.

This lets downstream consumers resolve newer compatible brick/math versions where their PHP/runtime constraints allow it.

Validation:

  • composer validate --strict
  • Local PHPUnit was not run because this fresh clone does not have dependencies installed.

@tacman
Copy link
Copy Markdown
Author

tacman commented May 22, 2026

Actually, I like #10 better. If needed, the application is responsible for installing it.

@tacman tacman marked this pull request as ready for review May 22, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant