Fix template resource config filename and item uriTemplate#141
Open
curler7 wants to merge 1 commit intoSylius:1.1from
Open
Fix template resource config filename and item uriTemplate#141curler7 wants to merge 1 commit intoSylius:1.1from
curler7 wants to merge 1 commit intoSylius:1.1from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[BC] Rename Template resource config file and unify shop template item URI
Description
This PR introduces two changes to the CMS Template shop API resource configuration:
Renames the incorrectly named file:
Tempalate.xml→Template.xmlUpdates the item operation
uriTemplatefrom:/shop/cms/template/{id}to:
/shop/cms/templates/{id}The goal is to align the item endpoint with the collection endpoint:
/shop/cms/templates/shop/cms/templates/{id}Rationale
template) while the collection uses a plural form (templates).This change modifies a public API endpoint:
/shop/cms/template/{id}
is replaced by:
/shop/cms/templates/{id}
If the singular endpoint is already used in production integrations, this constitutes a backward compatibility break.
Please advise whether:
How to verify
bin/console debug:router | grep cms
Expected output includes:
/shop/cms/templates
/shop/cms/templates/{id}
Checklist