Skip to content

fix: do not fail builds when refreshing them from another user#1343

Merged
leafty merged 3 commits into
mainfrom
leafty/fix-builds-no-peeking
Jun 10, 2026
Merged

fix: do not fail builds when refreshing them from another user#1343
leafty merged 3 commits into
mainfrom
leafty/fix-builds-no-peeking

Conversation

@leafty

@leafty leafty commented Jun 5, 2026

Copy link
Copy Markdown
Member

Closes #1338.

Updated permissions:

API Endpoint db.py method Description Required Permission
GET /builds/<build_id> get_build() Get a single build item Project Read
GET /environments/<environment_id>/builds get_environment_builds() List the build history for a launcher Project Read
POST /environments/<environment_id>/builds start_build() Rebuild (build a new image for the launcher) Project Write
PATCH /builds/<build_id> update_build() Cancel a build Project Write
GET /builds/<build_id>/logs get_build_logs() Get a build's logs Project Write
- _refresh_build() Refresh build status Project Read (checked before calling)

/deploy extra-values=dataService.imageBuilders.enabled=true,dataService.imageBuilders.strategyName=renku-buildpacks-v3,dataService.imageBuilders.outputImagePrefix=harbor.dev.renku.ch/renku-build/,dataService.imageBuilders.nodeSelector.renku.io/node-purpose=user,dataService.imageBuilders.tolerations[0].effect=NoSchedule,dataService.imageBuilders.tolerations[0].key=renku.io/dedicated,dataService.imageBuilders.tolerations[0].operator=Equal,dataService.imageBuilders.tolerations[0].value=user

@RenkuBot

Copy link
Copy Markdown
Contributor

You can access the deployment of this PR at https://renku-ci-ds-1343.dev.renku.ch

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 27268239456

Coverage decreased (-0.04%) to 86.372%

Details

  • Coverage decreased (-0.04%) from the base build.
  • Patch coverage: 4 uncovered changes across 2 files (9 of 13 lines covered, 69.23%).
  • 27 coverage regressions across 10 files.

Uncovered Changes

File Changed Covered %
components/renku_data_services/session/db.py 9 7 77.78%
components/renku_data_services/session/k8s_client.py 4 2 50.0%

Coverage Regressions

27 previously-covered lines in 10 files lost coverage.

File Lines Losing Coverage Coverage
components/renku_data_services/notifications/core.py 9 30.95%
components/renku_data_services/crc/core.py 4 78.57%
components/renku_data_services/resource_usage/core.py 4 50.83%
components/renku_data_services/k8s/watcher/core.py 2 78.75%
components/renku_data_services/crc/blueprints.py 2 96.64%
components/renku_data_services/storage/blueprints.py 2 92.91%
components/renku_data_services/base_api/error_handler.py 1 91.75%
components/renku_data_services/users/db.py 1 90.36%
components/renku_data_services/resource_usage/blueprints.py 1 94.85%
components/renku_data_services/session/models.py 1 94.19%

Coverage Stats

Coverage Status
Relevant Lines: 31186
Covered Lines: 26936
Line Coverage: 86.37%
Coverage Strength: 1.5 hits per line

💛 - Coveralls

@leafty leafty marked this pull request as ready for review June 10, 2026 11:27
@leafty leafty requested review from a team, SalimKayal and sgaist as code owners June 10, 2026 11:27

@sgaist sgaist left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leafty leafty merged commit aba6234 into main Jun 10, 2026
54 of 56 checks passed
@leafty leafty deleted the leafty/fix-builds-no-peeking branch June 10, 2026 13:33
@RenkuBot

Copy link
Copy Markdown
Contributor

Tearing down the temporary RenkuLab deployment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Buildruns: "no peeking allowed" issue

5 participants