feat: Allow multiple jobs per job launcher#1328
Conversation
|
You can access the deployment of this PR at https://renku-ci-ds-1328.dev.renku.ch |
eikek
force-pushed
the
eikek/multiple-jobs-per-launcher
branch
from
970d871 to
ae9e285
Compare
eikek
force-pushed
the
eikek/multiple-jobs-per-launcher
branch
4 times, most recently
from
4916193 to
02c78a5
Compare
olevski
left a comment
olevski
left a comment
There was a problem hiding this comment.
A few minor changes Eike. Everything else look good.
| prefix = f"{prefix}{safe_username}" | ||
| if submission_id: | ||
| prefix = f"{prefix}_{submission_id}" | ||
| prefix = f"j-{prefix}-{submission_id}" |
There was a problem hiding this comment.
Do we really need the j- prefix? This eats out 2 characters out of the 12 available.
There was a problem hiding this comment.
oh right, i overlooked that the caller only takes the first 12 characters of the result of that function. As I understood, the j- is for ui purposes for admins, right? So perhaps we can remove it to save two characters. I don't have a strong opinion, though, slightly in favor of not using j-.
There was a problem hiding this comment.
See the other comment. It is so that all jobs show up together when you list them. If we dont add this, the jobs show up interspersed with all the renku services and renku sessions. And it is hard to see what is what. It is also hard to see at a glance what is a job and what is not when looking at pods. So it just for admins. And I think is worth it. I have gotten similar requests even for session from admins.
There was a problem hiding this comment.
Would this be better served by using k8s labels?
eikek
force-pushed
the
eikek/multiple-jobs-per-launcher
branch
from
d02c450 to
0feb343
Compare
eikek
force-pushed
the
eikek/multiple-jobs-per-launcher
branch
from
0feb343 to
19176c7
Compare
The job command is stored in the environment as command+args
it is harder to map back to the original input, because it is not stored as given, but mapped to underlying platform
Amalthea sets it whenever the job goes to Failed or Succeeded
eikek
force-pushed
the
eikek/multiple-jobs-per-launcher
branch
from
1313956 to
fa1a651
Compare
6 participants
/deploy extra-values=dataService.imageBuilders.enabled=true,dataService.imageBuilders.strategyName=renku-buildpacks-v3,dataService.imageBuilders.outputImagePrefix=harbor.dev.renku.ch/renku-build/,dataService.imageBuilders.nodeSelector.renku.io/node-purpose=user,dataService.imageBuilders.tolerations[0].effect=NoSchedule,dataService.imageBuilders.tolerations[0].key=renku.io/dedicated,dataService.imageBuilders.tolerations[0].operator=Equal,dataService.imageBuilders.tolerations[0].value=user amalthea-sessions=main