Conversation
This PR adds full Arabic language support to Dicio, including: - Arabic voice command sentences for all skills (weather, search, timer, calculator, navigation, media, etc.) - Support for both Modern Standard Arabic (الفصحى) and Gulf Arabic dialect (اللهجة الخليجية) - Added Arabic (العربية) to the language selection list Voice command examples: - Weather: كيف الجو؟ / شو الطقس في دبي؟ - Open apps: افتح واتساب / شغل يوتيوب - Time: كم الساعة؟ / شو الوقت؟ - Search: ابحث عن... / دور لي على... - Call: اتصل على أحمد / كلم محمد - Timer: ضع منبه 5 دقائق / ذكرني بعد ساعة - Navigation: خذني للمطار / وين أقرب مطعم؟ - Media: شغل الموسيقى / الأغنية الجاية The Arabic UI translation already exists in values-ar/strings.xml, this PR enables Arabic as a selectable language option.
|
Hi @salktbi902, thank you for the PR! At a first glance the translations you made look ok. It seems like you accidentally closed the PR by deleting the fork, was that on purpose? Should this still be merged? |
There was a problem hiding this comment.
Thank you very much! You followed the dicio-sentences-compiler syntax properly, since the app compiled right away. I tested all the sentences you provided and only found one that does not work with the translations you provided.
Btw the timer and calculator won't be usable anyway because dicio-numbers is not translated, so don't bother testing them. For the joke skill instead, the current jokes API does not provide arabic jokes, so ignore that one too (or if you want create a PR to add support for another API that does support arabic jokes).
Ah, one thing you need to also do is add "Arabic" to the list of languages in the README and in fastlane/metadata/android/en-US/full_description.txt
I built a debug APK that you can try out and see which sentences work and which don't: https://github.com/Stypox/testing-apks/releases/download/29/app-debug.apk . Feel free to make more changes, push them (in a new PR since this one can't be reopened), play with the new debug APK built by the CI*, if needed make more changes, and once you are happy with the result let me know and I will proceed to merge.
* In the new PR, the APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
| next: | ||
| - الاغنية|المقطع التالي|الجاي|اللي بعد | ||
| - تخطى|تجاوز (الاغنية|المقطع)? | ||
| - الاغنية الجاية|التالية |
There was a problem hiding this comment.
It seems like the الأغنية الجاية sentence you suggested doesn't get interpreted correctly by these translations
| // a sudden change of selected language. Please avoid that. | ||
| enum Language { | ||
| LANGUAGE_SYSTEM = 0; | ||
| LANGUAGE_AR = 15; // Arabic (العربية) |
There was a problem hiding this comment.
On the master branch Turkish was also added, so this will have to become 16. Also, for consistency, don't include the (العربية)
Stypox
added
the
waiting-for-author
2 participants
This PR adds full Arabic language support to Dicio, including:
Voice command examples:
The Arabic UI translation already exists in values-ar/strings.xml, this PR enables Arabic as a selectable language option.