Review build process for ldap and rbac #716

Activity

1. cognifloyd

   added this to the 3.7.0 milestone on Apr 6, 2022
2. arm4b commented on Apr 7, 2022

   

   arm4b

   on Apr 7, 2022

   Last edited by arm4b

   Member

   More actions

   Based on https://github.com/StackStorm/st2/blob/e2e4e26381841e57193129a8b5beeefbe1c256aa/requirements.txt#L21-L25

   git+https://github.com/StackStorm/orquesta.git@v1.5.0#egg=orquesta
   git+https://github.com/StackStorm/st2-auth-backend-flat-file.git@master#egg=st2-auth-backend-flat-file
   git+https://github.com/StackStorm/st2-auth-ldap.git@master#egg=st2-auth-ldap
   git+https://github.com/StackStorm/st2-rbac-backend.git@master#egg=st2-rbac-backend
   

   we have orquesta, st2-auth-backend-flat-file, st2-auth-ldap and st2-rbac-backend affected by this.

   I'm including Orquesta in the list, because its version is bumped manually once in several months or before the st2 release, but not on every change which results in the same result.
   So doing a version bump/release in these repos might be one solution, but really just increases the overhead and maintenance burden as for every PR you want to do a repo release and then go to st2 repo requirements, updating the tag.

   ---

   The fundamental solution to me looks like fully moving both https://github.com/StackStorm/st2-rbac-backend and https://github.com/StackStorm/st2-auth-ldap codebase into the st2 repository. LDAP & RBAC have dedicated repositories just because these modules were enterprise and private before. Now both are core non-optional components of st2.

   This would really reduce the maintenance burden, rather than increase it. The downside might be losing some modularity?

   ---

   In a 3rd view, everything is about tradeoffs. Is it really a problem considering how frequently these repos change?

   For st2 master, on every next push or merge the rebuild would already happen by automatically picking up the latest code. And we do update st2 frequently. On release, the changes will be picked up in any way as automation creates a vX.Y stable branch for every repo.
3. arm4b

   added

   refactor

   on Apr 7, 2022
4. cognifloyd commented on Apr 28, 2022

   

   cognifloyd

   on Apr 28, 2022

   MemberAuthor

   More actions

   We are already publishing st2client wheels in the st2cd pack:
   https://github.com/StackStorm/st2cd/blob/0e7b5760a9163aedf486a071514e1d787392f444/actions/workflows/st2_finalize_release.yaml#L83-L87

   So, we should be able to do something similar with st2-auth-backend-flat-file, st2-auth-ldap, st2-rbac-backend, and orquesta.

   Of these 4, only orquesta has been released on pypi before, but the release is out-of-date: https://pypi.org/project/orquesta/#history

   I'm going to punt releasing these on pypi, or merging them into our st2 monorepo for a future release, not 3.7.0.
5. cognifloyd

   modified the milestones: 3.7.0, 3.8.0 on Apr 28, 2022
6. cognifloyd

   moved this to To do in StackStorm v3.8.0on Jul 10, 2022
7. cognifloyd

   added this to StackStorm v3.8.0on Jul 10, 2022