fix(ci): add submodules checkout to coverage job #85
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The coverage job was failing because the stackone-ai-node submodule was not being checked out. The MCP mock server tests require this submodule to be present for bun install to succeed. Changes: - Add submodules: true to coverage job checkout step (matching ci job) - Add automatic submodule initialisation in flake.nix shellHook This ensures submodules are available both in CI and local development.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a CI coverage job failure caused by a missing git submodule checkout step. The coverage job was failing because the vendor/stackone-ai-node submodule was not being initialized, while the main CI job already had this configuration.
- Added
submodules: trueto the coverage job's checkout step in the CI workflow - Added automatic git submodule initialization to the Nix development shell for local development
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/ci.yaml |
Added submodules: true parameter to coverage job checkout step to align with the ci job configuration |
flake.nix |
Added conditional logic in shellHook to automatically initialize git submodules when entering the development environment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix CI coverage job failure caused by missing git submodule checkout.
What Changed
submodules: trueto coverage job checkout step in CI workflowWhy
The coverage job was failing with:
This occurred because
vendor/stackone-ai-nodesubmodule was not checked out. Thecijob hadsubmodules: truebut thecoveragejob did not.Related
Fixes failed run: https://github.com/StackOneHQ/stackone-ai-python/actions/runs/20637603873
Summary by cubic
Fixes CI coverage job failures by checking out required git submodules. Also auto-initializes submodules in local development to prevent setup issues.
Written for commit a91fc08. Summary will update on new commits.