Closed
Conversation
# Conflicts: # integration_tests_split/spynnaker.cfg # integration_tests_split/test_scripts.py
rowleya
reviewed
Feb 9, 2026
Comment on lines
-54
to
-59
| def test_examples_balanced_random_balanced_random(self): | ||
| self.check_script("examples/balanced_random/balanced_random.py") | ||
|
|
||
| def test_examples_balanced_random_split_balanced_random_split(self): | ||
| self.check_script("examples/balanced_random/split/balanced_random_split.py") | ||
|
|
Member
There was a problem hiding this comment.
Do we want to get rid of these as well?
rowleya
reviewed
Feb 9, 2026
Member
rowleya
left a comment
rowleya
left a comment
There was a problem hiding this comment.
Checking this having looked at sPyNNaker... wondering...
Comment on lines
+3
to
+8
| n_synapse_cores = spynnaker.pyNN.models.neuron.builds.if_cond_exp_stoc:IFCondExpStoc:1, | ||
| spynnaker.pyNN.models.neuron.builds.if_curr_exp_ca2_adaptive:IFCurrExpCa2Adaptive:1, | ||
| spynnaker.pyNN.models.neuron.builds.if_curr_dual_exp_base:IFCurrDualExpBase:1, | ||
| spynnaker.pyNN.models.neuron.builds.if_curr_exp_semd_base:IFCurrExpSEMDBase:1, | ||
| spynnaker.pyNN.models.neuron.builds.if_curr_exp_base:IFCurrExpBase:1 | ||
|
|
Member
There was a problem hiding this comment.
Is there a reason this couldn't just be done in the script that uses them?
Member
Author
|
replaced by #142 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on SpiNNakerManchester/TestBase#72
Adds a new example to test a binary
Uses the cfg to run a number of example in split mode.
integration_tests_split/test_scripts.py
runs these and shows the binary tested
changes to integration_tests/test_scripts.py are just what the automated script builder did.
That is what is actually tested.
tested by https://github.com/SpiNNakerManchester/IntegrationTests/actions/runs/21713093809