improve logging for k8s_node_distribution_check#1105
Open
depressiveRobot wants to merge 1 commit intomainfrom
Open
improve logging for k8s_node_distribution_check#1105depressiveRobot wants to merge 1 commit intomainfrom
depressiveRobot wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Marvin Frommhold <depressiveRobot@users.noreply.github.com>
depressiveRobot
added
enhancement
mbuechse
reviewed
Feb 18, 2026
| # if node_type == "control": | ||
| # raise DistributionException("The distribution of nodes described in the standard couldn't be detected.") | ||
| logger.warning("No node distribution could be detected for the worker nodes. " | ||
| if node_type == "worker": |
Contributor
There was a problem hiding this comment.
This change introduces two mistakes:
a) this warning applies to all kinds of nodes (the text in the warning is wrong)
b) you messed up the indentation (see flake8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly improves logging to avoid confusion/be more explicit.