Skip to content

Remove Node.js version filter from optimize #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdalton wants to merge 1 commit into
base: v1.x
Choose a base branch
from
Open

Remove Node.js version filter from optimize #1006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/commands/optimize/add-overrides.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,21 +109,13 @@ export async function addOverrides(

const depAliasMap = new Map<string, string>()
const depEntries = getDependencyEntries(pkgEnvDetails)
const manifestEntries = manifestNpmOverrides.filter(({ 1: data }) =>
semver.satisfies(
// Roughly check Node range as semver.coerce will strip leading
// v's, carets (^), comparators (<,<=,>,>=,=), and tildes (~).
semver.coerce(data.engines.node)!,
pkgEnvDetails.pkgRequirements.node,
),
)

const addingText = `Adding overrides to ${workspace}...`
let loggedAddingText = false

// Chunk package names to process them in parallel 3 at a time.
await pEach(
manifestEntries,
manifestNpmOverrides,
async ({ 1: data }) => {
const { name: sockRegPkgName, package: origPkgName, version } = data
const major = getMajor(version)!
Expand Down