Skip to content

Fix (seeding) Randomness utility#644

Open
svij-sc wants to merge 2 commits into
mainfrom
svij/update-random-seed
Open

Fix (seeding) Randomness utility#644
svij-sc wants to merge 2 commits into
mainfrom
svij/update-random-seed

Conversation

@svij-sc
Copy link
Copy Markdown
Collaborator

@svij-sc svij-sc commented May 18, 2026

Updating random --> determinisitc utility:

  1. Remove TF as we are not using it anymore
  2. Simplify defaults and update what is being called according to recent dependency updates.

@svij-sc svij-sc changed the title Fix Randomness utility Fix (seeding) Randomness utility May 18, 2026
Copy link
Copy Markdown
Collaborator

@mkolodner-sc mkolodner-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

throughput and should not be enabled for training or for production inference - can be used for debugging purposes.

np.random.seed(seed)
- Important: Graph Sampling currently do not follow determism outlined here.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: determism

"""
random.seed(seed)
np.random.seed(seed)
torch.manual_seed(seed)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also do torch.cuda.manual_seed_all(seed) as is done here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants