Update GBML Config Wrapper to house {node|edge}_type_to_*_maps.#643
Queued
svij-sc wants to merge 3 commits into
Queued
Update GBML Config Wrapper to house {node|edge}_type_to_*_maps.#643svij-sc wants to merge 3 commits into
svij-sc wants to merge 3 commits into
Conversation
svij-sc
requested review from
kmontemayor2-sc,
mkolodner-sc,
nshah-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
svij-sc
commented
May 18, 2026
mkolodner-sc
approved these changes
May 20, 2026
kmontemayor2-sc
approved these changes
May 20, 2026
Collaborator
kmontemayor2-sc
left a comment
kmontemayor2-sc
left a comment
There was a problem hiding this comment.
Thanks Shubham! I'd prefer if we can have some follow up to update our examples, or at least some tracker that we should do so :)
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change one would need to manually convert
condensed_{node|edge}_type_*_mapsmanually to{node|edge}_type_to_*_mapsusing information available ingraph_metadata. This causes a lot of duplicity in code when we can just create convenience functions in the gbml wrapper.