Skip to content

Add shinasystem's SiHAS Door Lock - #3344

Open
shinasys wants to merge 5 commits into
SmartThingsCommunity:mainfrom
shinasys:add-sihas-dlm-300z-lock
Open

Add shinasystem's SiHAS Door Lock#3344
shinasys wants to merge 5 commits into
SmartThingsCommunity:mainfrom
shinasys:add-sihas-dlm-300z-lock

Conversation

@shinasys

@shinasys shinasys commented Nov 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

  • Test Suite
    Test session: LCALTE8HK2

@github-actions

github-actions Bot commented Nov 11, 2026

Copy link
Copy Markdown

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions

github-actions Bot commented Nov 11, 2026

Copy link
Copy Markdown

Profile category check: ✅ Passed - all profiles have a category defined.

@github-actions

github-actions Bot commented Nov 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

   73 files    571 suites   0s ⏱️
3 375 tests 3 375 ✅ 0 💤 0 ❌
5 414 runs  5 414 ✅ 0 💤 0 ❌

Results for commit 782482a.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Nov 11, 2026 •
edited
Loading

Copy link
Copy Markdown

zigbee-lock_coverage.xml

File Coverage
All files 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_handlers/zigbee_responses.lua 87% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_handlers/capabilities.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/init.lua 99% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/configurations.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_utils/utils.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_utils/tables.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/samsungsds/init.lua 89% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/legacy-handlers/yale/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/legacy-handlers/migrate.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/legacy-handlers/init.lua 95% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 782482a

@github-actions

github-actions Bot commented Nov 11, 2026

Copy link
Copy Markdown

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/Q1jPGD8EWglL

@shinasys shinasys changed the title Add shinasystem's SiHAS Smoke Detector Add shinasystem's SiHAS Door Lock Nov 11, 2026
@shinasys
Use doorState capability instead of contactSensor for SiHAS Door Lock
a88cb49 
- Replace contactSensor with doorState in the profile, and rename the
  profile to base-lock-door-state
- Report supportedDoorStates (open, closed) on init
- Update the fingerprint and the tests accordingly
@shinasys
Merge branch 'main' into add-sihas-dlm-300z-lock
5a781c2
@shinasys
Update the SiHAS Door Lock test for the credential table changes in S…
782482a 
…martThingsCommunity#3331
@hcarter-775
hcarter-775 self-requested a review November 13, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjswedes cjswedes Awaiting requested review from cjswedes
@aleclorimer aleclorimer Awaiting requested review from aleclorimer
@hcarter-775 hcarter-775 Awaiting requested review from hcarter-775

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shinasys