Repository navigation
Conversation
…file - Report Yale alarm v1 type 144 (key tag/card unlock) as an rfid unlock with the tag slot as codeId; previously it was ignored - Map alarm 21 level 1 to a manual lock on the Conexis, which has no keypad (the handle is lifted); other Yale locks keep keypad - Feed alarm v1 lock events from Yale locks into the existing lock event delay bookkeeping, as the Notification handlers already do. The lock sends a Door Lock Operation Report ~1s before the alarm, so the detailed event was dropped as a repeat of the current state - Use base-lock-tamper for the Yale/Conexis fingerprint so the wrong-tag lockout alarm (161) is shown Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
These fixes are for the Yale Conexis L1/L2 with the Yale Z-Wave module (
Yale/Conexis,0x0129 / 0x6600 / 0x0002). The lock reports how it was operated with alarm v1 reports, which currently lose detail or are dropped:unlockedwithmethod = "rfid"and the slot ascodeId, for Yale locks only.method = "manual"for the Conexis only, so other Yale locks keep the current behaviour.DELAY_LOCK_EVENTbookkeeping so the plain report is held and replaced. This applies the same bookkeeping (lock_utils.handle_alarm_lock_event_delay) to alarm v1 lock events from Yale locks. It's limited to Yale because that's what I could test; other alarm v1 locks may have the same problem.Yale/Conexisfingerprint usedbase-lock, which has notamperAlert, so the wrong-tag lockout (alarm 161) was never shown. It now usesbase-lock-tamper.Summary of Completed Tests
test_yale_conexis_alarms.luahas 6 tests:zwave-locktests pass under Lua 5.3 with lua_libsapiv21_62, andluacheckreports 0 warnings and 0 errors on the changed files.logcatfor tag unlocks (alarm 144, slot 3), handle lock and unlock (21/22), remote lock and unlock (24/25) and auto-relock (27), and confirmed the resulting events in device History. This exact branch hasn't been deployed to the device.🤖 Generated with Claude Code