Repository navigation
zigbee-lock: support programmingUser typed entries - #3332
Merged
Merged
Conversation
|
Channel deleted. |
|
zigbee-lock_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 6b63c58 |
Test Results 73 files 571 suites 0s ⏱️ Results for commit 6b63c58. ♻️ This comment has been updated with latest results. |
hcarter-775
force-pushed
the
feat/zigbee-lock-master-code-distinct
branch
from
November 6, 2026 18:15
bb08c2c to
b71ef21
Compare
hcarter-775
force-pushed
the
simplify-reported-cred-management
branch
from
November 6, 2026 19:59
1eab2cd to
528c7fb
Compare
hcarter-775
force-pushed
the
feat/zigbee-lock-master-code-distinct
branch
from
November 6, 2026 20:00
b71ef21 to
8e976ad
Compare
hcarter-775
force-pushed
the
simplify-reported-cred-management
branch
from
November 9, 2026 21:34
528c7fb to
4192673
Compare
hcarter-775
force-pushed
the
feat/zigbee-lock-master-code-distinct
branch
from
November 11, 2026 17:48
8e976ad to
d96af15
Compare
Represent the Zigbee master code (credential index 0) as a master user, keep it across delete-all, and promote reported codes to master when the lock says so. A user cannot be changed to or from the master type via updateUser, and auto-assigned credentials start at index 1 so they never claim the master slot. Move Yale-specific handling into its own sub-driver, which normalizes Yale's misreported user ids and refuses to delete the master code. Extend the lockCodes migration to take the known master code slot (0 for Yale) and always migrate it as a master user. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
hcarter-775
force-pushed
the
feat/zigbee-lock-master-code-distinct
branch
from
November 12, 2026 17:29
2f1c3fd to
7e9a2d7
Compare
hcarter-775
changed the title
tpmanley
approved these changes
Nov 12, 2026
tpmanley
left a comment
tpmanley
left a comment
Contributor
There was a problem hiding this comment.
Looks like you handled all the stuff we discussed offline so I think this look good to go
ctowns
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Represent the Zigbee master code pins as a programmingUser, keep it across delete-all, refuse to delete these kinds of codes, refuse to create these kinds of codes, and promote reported codes to master when the lock says so. A user cannot be changed to or from the programmingUser type via updateUser, and auto-assigned credentials start at index 1 so they never claim the master slot.
Move Yale-specific handling into its own sub-driver, which normalizes Yale's misreported user ids.
Extend the lockCodes migration to take the known master code slot (0 for Yale) and always migrate it as a programming user.
Summary of Completed Tests
Tested on-device. Unit tests updated.