Repository navigation
feat(zigbee-lock): validate indices during lockCodes migration - #3327
Merged
Merged
Conversation
hcarter-775
force-pushed
the
feat/zigbee-lock-migration-validation
branch
from
November 4, 2026 17:43
77d931e to
a7253f0
Compare
|
Channel deleted. |
|
zigbee-lock_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 867cea4 |
|
|
Test Results 73 files 548 suites 0s ⏱️ Results for commit 867cea4. ♻️ This comment has been updated with latest results. |
Drop lockCodes slots that are not integer credential indices, or fall below the credential minimum, instead of migrating them. Slot 0 is a valid credential index but not a valid user index (minimum 1), so its user takes the lowest unused userIndex without displacing any slot whose number is already a valid userIndex. Move the migration into its own module and add per-table minimums to the table definitions. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
hcarter-775
force-pushed
the
feat/zigbee-lock-migration-validation
branch
from
November 4, 2026 18:34
a7253f0 to
867cea4
Compare
tpmanley
approved these changes
Nov 4, 2026
ctowns
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop lockCodes slots that are not integer credential indices, or fall below the credential minimum, instead of migrating them. Slot 0 is a valid credential index but not a valid user index (minimum 1), so its user takes the lowest unused userIndex without displacing any slot whose number is already a valid userIndex.
Move the migration into its own module and add per-table minimums to the table definitions.
Summary of Completed Tests
Unit tests updated. Tested on Zigbee Yale and Kwikset devices.