Skip to content

Production Release 11/4 - #3326

Merged
ctowns merged 2 commits into
productionfrom
cherry-pick/prod-11-4
Nov 4, 2026
Merged

ctowns merged 2 commits into
productionfrom
cherry-pick/prod-11-4

Conversation

@ctowns

@ctowns ctowns commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Production release 11/4

viys and others added 2 commits November 3, 2026 16:12
* Add SONOFF TP-WGZBA support to zigbee-thermostat

* Fix TP-WGZBA heating setpoint tests for API 57 compatibility

* Fix TP-WGZBA tests without custom capability definitions

* Add TP-WGZBA can_handle test coverage

* Fix TP-WGZBA firmware version reporting

* Fix TP-WGZBA review findings

* Address TP-WGZBA review feedback

- Encode boolean preferences backed by Uint8 attributes as 0/1 so the Bluetooth pairing broadcast write is actually sent.
- Build the temporary-mode payload with string.pack; keep the frame without a manufacturer code, as required by the device firmware.
- Rely on base driver and default handlers for temperature, heating setpoint, thermostat mode, running state, driverSwitched and firmware version.
- Emit supported thermostat modes in doConfigure.
- Shorten preference names to the platform's 24-character limit.

* Extend TP-WGZBA temperature calibration range to +/-10 C
* feat:sonoff swv2c valve

* Zigbee Value:
1、Add Sonoff valve subdriver lazy loading.
2、Modify comment language and file name

* Address SWV2C review feedback

* Configure SWV2C reporting and fix integration tests

* Remove duplicate Zigbee valve health check setting

* fix: guard SWV2C endpoint 2 reports until child exists

* fix: handle SWV2C identify reports and use default battery reporting

* Remove redundant power source capability from SWV2C

* Reuse valve battery profile for SWV2C

---------

Co-authored-by: Konrad K <33450498+KKlimczukS@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Profile category check: ✅ Passed - all profiles have a category defined.

@ctowns ctowns changed the title Cherry pick/prod 11 4 Production Release 11/4 Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Channel deleted.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Test Results

   73 files    544 suites   0s ⏱️
3 304 tests 3 304 ✅ 0 💤 0 ❌
5 320 runs  5 320 ✅ 0 💤 0 ❌

Results for commit bb875ba.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

zigbee-thermostat_coverage.xml

File Coverage
All files 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/stelpro/init.lua 87% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/lux-konoz/can_handle.lua 83% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/vimar/init.lua 89% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/sinope/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/sonoff/tp_wgzba/init.lua 82% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/popp/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/stelpro-ki-zigbee-thermostat/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/wallhero/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/aqara/init.lua 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/resideo_korea/init.lua 90% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/zenwithin/init.lua 97% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against bb875ba

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

zigbee-valve_coverage.xml

File Coverage
All files 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-valve/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-valve/src/sonoff/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-valve/src/sinope/init.lua 97% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against bb875ba

@ctowns

ctowns commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

Confirmed that jenkins tests passed, the CI pending checks are a result of a reporting issue rather than any issue in the tests.

@ctowns
ctowns merged commit cd90975 into production Nov 4, 2026
21 of 27 checks passed
@ctowns
ctowns deleted the cherry-pick/prod-11-4 branch November 4, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants