Implement sRGB support for ASTC decoding - #57
Open
Erik-White wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Adds sRGB decoding support to the ASTC decoder, it was previously linear only. KTX/KTX2 *_SRGB_ASTC textures now decode with the ASTC spec sRGB endpoint expansion (RGB low byte 0x80, alpha stays linear) instead of linear replication.
There is a bit of churn in the existing test data where I have updated a couple of test methods to correct the (RGB/RGBA) naming. Some of the TestImage naming was also updated for better consistency
Background
KTX/KTX2 files carry ASTC data in two flavours, *_UNORM_BLOCK and *_SRGB_BLOCK. The block payload is identical but the format tag tells the decoder how to expand endpoints. Previously this decoder ignored that distinction and always used linear expansion, so *_SRGB_ASTC textures decoded with wrong pixel values.
Implementation