Skip to content

Fix pointer size for BRAM FIFO #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbespin merged 1 commit into from
Jan 30, 2026
Merged

Fix pointer size for BRAM FIFO #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions basil/firmware/modules/bram_fifo/bram_fifo_core.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,7 @@ wire FULL_BUF;

assign FIFO_READ_NEXT_OUT = !FULL_BUF;

`include "../includes/log2func.v"
localparam POINTER_SIZE = `CLOG2(DEPTH);
localparam POINTER_SIZE = 32;

generic_fifo #(
.DATA_SIZE(32),
Expand All @@ -132,7 +131,6 @@ generic_fifo #(
.data_out(FIFO_DATA_BUF[31:0]),
.size(CONF_SIZE[POINTER_SIZE-1:0])
);
assign CONF_SIZE[31:POINTER_SIZE] = 0;

always @(posedge BUS_CLK)
BUS_DATA_OUT_DATA <= FIFO_DATA_BUF;
Expand Down
2 changes: 1 addition & 1 deletion basil/firmware/modules/utils/generic_fifo.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ output reg [DATA_SIZE-1:0] data_out;

reg [DATA_SIZE:0] mem [DEPTH-1:0];

localparam POINTER_SIZE = 16;
localparam POINTER_SIZE = 32;

reg [POINTER_SIZE-1:0] rd_pointer, rd_tmp, wr_pointer;
output reg [POINTER_SIZE-1:0] size;
Expand Down