Repository navigation
fix(theme-check-docs-updater): remove invalid metaobject default - #1334
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Fixes #827. The
theme/setting.jsonschema currently includesdefaultformetaobjectsettings, although that attribute is unsupported. Normalize the loaded schema to remove it so the editor does not suggest it and validation rejects it.What's next? Any followup issues?
None.
What did you learn?
Theme setting property suggestions are driven by the JSON schema loaded from theme-liquid-docs.
Tophatting
No visual change. The schema behaviour is covered by the regression test.
Before you deploy
changeset.Validation run:
vitest run packages/theme-check-docs-updater/src(6 tests passed)pnpm --filter @shopify/theme-check-docs-updater type-checkpnpm --filter @shopify/theme-check-docs-updater build:tsgit diff --check