Skip to content

Add dead code candidates endpoint - #1010

Merged
mathyasp merged 4 commits into
mainfrom
mathyasp/add-dead-code-candidates-endpoint
Aug 21, 2026
Merged

Add dead code candidates endpoint#1010
mathyasp merged 4 commits into
mainfrom
mathyasp/add-dead-code-candidates-endpoint

Conversation

@mathyasp

@mathyasp mathyasp commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Adds dead_code_candidates endpoint
  • Adds 2 filters, intentionally as a separate commit so it can be removed if there's disagreement
    • Skip declarations with no definitions (avoids reporting phantom nodes the graph knows about but no source defines).
    • Skip declarations that have any rubydex-seeded built-in definition (avoids flagging String, Array, etc. even when user code reopens them).

@mathyasp mathyasp self-assigned this Aug 14, 2026
@mathyasp
mathyasp marked this pull request as ready for review August 14, 2026 22:10
@mathyasp
mathyasp requested a review from a team as a code owner August 14, 2026 22:10
vinistock
vinistock reviewed Aug 17, 2026
View reviewed changes
Comment thread rust/rubydex/src/query.rs Outdated
Comment thread rust/rubydex/src/query.rs Outdated
Comment thread rust/rubydex/src/query.rs Outdated
Comment thread ext/rubydex/graph.c Outdated
Comment thread test/graph_test.rb
@vinistock vinistock added the enhancement New feature or request label Aug 17, 2026
@mathyasp
mathyasp force-pushed the mathyasp/add-dead-code-candidates-endpoint branch from 5e9a5d3 to 2f4e129 Compare August 20, 2026 20:14
@mathyasp
mathyasp requested a review from vinistock August 20, 2026 21:25
vinistock
vinistock approved these changes Aug 21, 2026
View reviewed changes

@vinistock vinistock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Just a few improvements, but this is good to go

Comment thread rust/rubydex/src/query.rs Outdated
Comment thread rust/rubydex/src/query.rs Outdated
Comment thread rust/rubydex/src/query.rs Outdated
@mathyasp
mathyasp force-pushed the mathyasp/add-dead-code-candidates-endpoint branch from 2f4e129 to 2be46d0 Compare August 21, 2026 17:29
@mathyasp

mathyasp commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author
image

@mathyasp
mathyasp merged commit d7c7656 into main Aug 21, 2026
36 checks passed
@mathyasp
mathyasp deleted the mathyasp/add-dead-code-candidates-endpoint branch August 21, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinistock vinistock vinistock approved these changes

Assignees

@mathyasp mathyasp

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mathyasp @vinistock