Show task subjects in task updates - #1042
Draft
OllieinCanada wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Oliver Slapinski <olliefromcanada@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #988
Problem
Claude
TaskUpdatemessages only carry a task ID. Roast therefore renders output such as:The useful subject is available earlier, when the matching
TaskCreatecall and result establish the numeric task ID.Fix
TaskCreateID-to-subject associations in the existing per-invocation Claude context#idoutput when the create result is missing, failed, or has an unexpected shapeThe state remains local to one Claude invocation; there is no global cache or provider behavior change.
Evidence
The regression test failed on current
mainbefore the production change:After the fix:
bundle exec rake sorbet: no errorsbundle exec rake rubocop_ci: 156 files, no offensesbundle exec rake test: 1,240 runs, 2,166 assertions, 0 failures, 0 errors, 0 skipsgit diff --check: passesAll tests ran deterministically on Ruby 3.4/Linux without an LLM or external model API call.
AI assistance
Implementation and test drafting were AI-assisted. I reviewed the resulting diff and verified it with the repository's complete CI command set.