This repository was archived by the owner on Mar 7, 2018. It is now read-only.
FIX for application restart when srv not reachable#595
Open
v0lkan wants to merge 2 commits intoShopify:masterfrom
v0lkan:restart_fix
Open
FIX for application restart when srv not reachable#595v0lkan wants to merge 2 commits intoShopify:masterfrom v0lkan:restart_fix
v0lkan wants to merge 2 commits intoShopify:masterfrom
v0lkan:restart_fix
Conversation
v0lkan
commented
Jul 10, 2015
Tested on Mac OS X Yosemite, Chrome Version 43.0.2357.132 (64-bit)
Steps to reproduce:
1. Run service by `dashing start`
2. View a dashboard
3. kill the service by CTRL + D
4. wait for five minutes.
expectation:
page should reload
what happens:
e.currentTarget.readyState is 0 (not initialized)
chrome's EventSource API tries to reconnect to a non-existent server over and over again.
The page never refreshes.
We clear errorTimerId immediately after we get a message event, so that there won't be redundant restarts.
On an edge case, the service might reconnect and won't get any messages for a while which might trigger the timer with errorTimerId; and that will cause only one extra refresh only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.