Skip to content

Add typed JSON output to theme pull - #8917

Merged
gonzaloriestra merged 9 commits into
gonzalo/json-theme-pushfrom
gonzalo/json-theme-pull
Oct 16, 2026
Merged

gonzaloriestra merged 9 commits into
gonzalo/json-theme-pushfrom
gonzalo/json-theme-pull

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Original PR and review history: #8648.

WHY are these changes introduced?

Fixes https://github.com/shop/issues-develop/issues/23693

Theme downloads need a typed automation result.

WHAT is this pull request doing?

Add a strict JSON theme resource, absolute project directory and explicit outcomes. Retain cancellation, safety skips and all requested environment results while keeping download failures on the shared fatal path.

The public output follows docs/cli/json-output.md; explicitly named environments use one {environments: [...]} object.

How to manually test your changes?

shopify theme pull --theme <theme-id> --store example.myshopify.com --json
shopify theme pull --json-schema

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

@gonzaloriestra
gonzaloriestra added this pull request to stack #8925 October 15, 2026 12:34
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Oct 15, 2026
@gonzaloriestra gonzaloriestra changed the title gonzalo/json theme pull Add typed JSON output to theme pull Oct 15, 2026
@gonzaloriestra
gonzaloriestra marked this pull request as ready for review October 15, 2026 12:42
@gonzaloriestra
gonzaloriestra requested review from a team as code owners October 15, 2026 12:42
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-pull branch from a538b6d to f49da92 Compare October 15, 2026 13:33
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-pull branch from f49da92 to 994e2ea Compare October 15, 2026 13:52

@isaacroldan isaacroldan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new execution tests need their own store context.


🤖 Generated by the review-pr skill

Comment thread packages/theme/src/cli/services/pull/execute.test.ts
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-pull branch 2 times, most recently from 2f5eefc to 54bac46 Compare October 16, 2026 08:15
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-pull branch from 54bac46 to 293d453 Compare October 16, 2026 10:37
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Potential Breaking Changes Detected

This PR contains changes that may break the existing contract.

@shopify/dev_experience — this PR contains breaking changes that require coordination for the next major release.

📦 Major Version Changesets

The following changesets request a major version bump:

Changeset Package
theme-push-json-contract.md "@shopify/cli": major

@github-actions

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/themes/theme-manager.d.ts
@@ -11,5 +11,12 @@ export declare abstract class ThemeManager {
     findOrCreate(name?: string, role?: Role): Promise<Theme>;
     fetch(name?: string, role?: Role): Promise<Theme | undefined>;
     generateThemeName(context: string): string;
-    create(themeRole?: Role, themeName?: string): Promise<Theme>;
+    create(themeRole?: Role, themeName?: string): Promise<{
+        createdAtRuntime: boolean;
+        id: number;
+        name: string;
+        processing: boolean;
+        role: string;
+        src?: string;
+    }>;
 }
\ No newline at end of file

@karreiro karreiro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @gonzaloriestra!

@gonzaloriestra
gonzaloriestra added this pull request to the merge queue Oct 16, 2026
Merged via the queue into main with commit 060e88b Oct 16, 2026
35 of 59 checks passed
@gonzaloriestra
gonzaloriestra deleted the gonzalo/json-theme-pull branch October 16, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants