Add typed JSON output to theme check - #8642
Open
gonzaloriestra wants to merge 1 commit into
Open
gonzaloriestra wants to merge 1 commit into
gonzaloriestra wants to merge 1 commit into
Conversation
gonzaloriestra
added this pull request to stack #8644
September 24, 2026 09:19
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 24, 2026 10:04
60fc145 to
84774fa
Compare
gonzaloriestra
removed this pull request from stack #8644
September 24, 2026 10:04
gonzaloriestra
changed the base branch from
gonzalo/json-theme-list
to
gonzalo/json-theme-preview
September 24, 2026 10:05
gonzaloriestra
added this pull request to stack #8655
September 24, 2026 10:05
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 24, 2026 10:11
84774fa to
143d3dc
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
2 times, most recently
from
September 24, 2026 10:21
1e151c5 to
0bd24e9
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 24, 2026 10:25
0bd24e9 to
b1a9aff
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 24, 2026 11:56
b1a9aff to
cd8b847
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 24, 2026 13:46
cd8b847 to
ec6f23d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 24, 2026 14:21
ec6f23d to
861825a
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
2 times, most recently
from
September 25, 2026 11:43
6cae74e to
c218adb
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
2 times, most recently
from
September 25, 2026 12:27
fa74b25 to
d93ff1e
Compare
gonzaloriestra
removed this pull request from stack #8655
September 25, 2026 12:28
gonzaloriestra
added this pull request to stack #8673
September 25, 2026 12:29
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 28, 2026 08:20
d93ff1e to
1d49ce8
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 28, 2026 08:59
1d49ce8 to
3d5d370
Compare
gonzaloriestra
marked this pull request as ready for review
September 28, 2026 09:35
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 28, 2026 10:25
3d5d370 to
edcb032
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 28, 2026 11:39
edcb032 to
b23022c
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
2 times, most recently
from
September 29, 2026 10:28
c8a95e6 to
78b9ac4
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 29, 2026 11:11
78b9ac4 to
7b65981
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 29, 2026 11:38
7b65981 to
0dbe925
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 29, 2026 13:44
0dbe925 to
8a82337
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 29, 2026 14:18
8a82337 to
04343fc
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-check
branch
from
September 29, 2026 14:40
04343fc to
c6e17b3
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
theme check --output jsonhas an existing result shape but no discoverable schema or standard--jsonflag.Related to shop/issues-develop#23691.
WHAT is this pull request doing?
Add typed check results and
--json, preserving compact JSON, offense ordering, text output, auto-correction and failure exits. Keep the text adapter used bytheme push.Normal output for a clean theme:
Matching JSON:
Multiple environments emit one ordered
{environments: [{environment, result}]}document for both JSON flags. Failed environments remain on stderr and are omitted.--jsonis incompatible with--init,--version,--print, and--list; those modes keep their existing behavior without--json.Refreshes generated help and the manifest.
How to manually test your changes?
Checklist