Skip to content

Fix accelerated checkout button hit area - #515

Open
markmur wants to merge 1 commit into
mainfrom
fix/accelerated-checkout-button-height
Open

Fix accelerated checkout button hit area#515
markmur wants to merge 1 commit into
mainfrom
fix/accelerated-checkout-button-height

Conversation

@markmur

@markmur markmur commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove the default flex: 1 style from AcceleratedCheckoutButtons so the native onSizeChange height participates in Yoga layout
  • leave the native component unstyled until it reports a height, then apply only that height
  • update the regression test to ensure flex sizing cannot override the reported height again

Reproduction

Reproduced with Checkout Sheet Kit 3.8.1, Expo SDK 57, React Native 0.86.0, and an iOS 18 simulator. With two wallets, native reported 104 pt while the React Native frame remained 48 pt; taps on the visibly overflowing button edges were dropped. Removing flex: 1 made the React Native frame match the reported height.

Fixes #502

@markmur
markmur requested a review from a team as a code owner August 14, 2026 10:28
@github-actions

Copy link
Copy Markdown

Coverage Report

Lines Statements Branches Functions
Coverage: 99%
99.53% (213/214) 96.03% (121/126) 100% (64/64)

@markmur markmur self-assigned this Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant