Skip to content

Python: update MCP OAuth sample dependencies - #6

Open
anurag6569201 wants to merge 1 commit into
qa/agent-microsoft-semantic-kernel/pr-06-14352/basefrom
qa/agent-microsoft-semantic-kernel/pr-06-14352/head
Open

Python: update MCP OAuth sample dependencies#6
anurag6569201 wants to merge 1 commit into
qa/agent-microsoft-semantic-kernel/pr-06-14352/basefrom
qa/agent-microsoft-semantic-kernel/pr-06-14352/head

Conversation

@anurag6569201

Copy link
Copy Markdown

Motivation and Context

Keep the MCP OAuth demo aligned with the current Semantic Kernel Python SDK release and public API signatures.

Description

  • Update the sample's Semantic Kernel dependency to 1.44.1.
  • Refresh the lockfile for the updated dependency graph.
  • Align timeout and agent-thread type annotations with the current SDK APIs.

Contribution Checklist

Source merge-base: a64827ec8c5621eeaf7c4c5dabdb5355bb253177
Source head: e25bbf9a29198a3d78ad86ed8cb1dae7fb528897

@shipwright-agent

Copy link
Copy Markdown

⚠️ Shipwright · Approve with conditions

Recommendation: approve PR #6 with conditions · Tier T3
Checks: 0 total · 0 needing attention

Next step: an authorized approver must satisfy the approval condition.

Findings (6)

  • CRITICAL (unverified) The timeout argument changed from timedelta(seconds=60) to a bare float 60.0. · main.py:202
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.
  • CRITICAL (unverified) The variable was renamed from oath_plugin to oauth_plugin, but the diff does not show any corresponding update to the OAuth client configuration or token storage. · main.py:202
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.
  • CRITICAL (unverified) The lockfile pins azure-ai-agents to a pre-release beta version 1.2.0b6. · uv.lock:209
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.
  • CRITICAL (unverified) The lockfile upgrades openai from 1.93.3 to 3.3.1, a major version jump that switches the HTTP transport from httpx to httpx2 and removes distro/tqdm dependencies. · uv.lock:1317
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.
  • HIGH (unverified) The type annotation changed from ChatHistoryAgentThread to AgentThread, but the surrounding comments still say 'Create a thread to hold the conversation' and 'a new thread will be · main.py:210
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.
  • HIGH (unverified) The dependency specifier was tightened from semantic-kernel[mcp] to semantic-kernel[mcp]>=1.44.1, but the lockfile also pulls in a large set of transitive upgrades (anyio, openai, · pyproject.toml:10
    • Fix: Review the cited evidence, fix the risk if confirmed, and rerun Shipwright.

Conditions

  • human approval required (T3): apply the approval label

Fireworks usage: 61,542 input · 655 output · 62,197 total tokens · $0.0140 · 13s · 0 fix iteration(s)

Open the Shipwright check for full evidence and the audit bundle. Use /shipwright rerun to verify again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant