Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/_typos.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ extend-exclude = [

[default.extend-words]
ACI = "ACI" # Azure Container Instance
CPY = "CPY" # Ruff copyright lint rule prefix
exercize = "exercize" # test typos
gramatical = "gramatical" # test typos
Guid = "Guid" # Globally Unique Identifier
Expand Down
2 changes: 1 addition & 1 deletion docs/decisions/0031-feature-branch-strategy.md
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ Currently the priorities are ordered but not necessarily needs to be implemented

Chosen option: "Feature Branch Strategy", because it allows individual features to be developed in isolation, minimizing conflicts with the main branch and facilitating easier code reviews.

## Fequent Asked Questions
## Frequent Asked Questions

### Is there a migration strategy for initiatives that followed the old contribution way with forks, and now have to switch to branches in microsoft/semantic-kernel?

Expand Down
2 changes: 1 addition & 1 deletion docs/decisions/0035-skfunction-type-descriptions.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public sealed record FunctionView(
| Type | Pros | Cons |
| ------------------------- | ------------------------------------------------------------ | ---------------------------------------------------------- |
| JsonSchema.Net.JsonSchema | Popular and has frequent updates, built on top of System.Net | Takes a dependency on OSS in SK core |
| NJsonShema.JsonSchema | Very popular, frequent updates, long term project | Built on top of Json.Net (Newtonsoft) |
| NJsonSchema.JsonSchema | Very popular, frequent updates, long term project | Built on top of Json.Net (Newtonsoft) |
| JsonDocument | Native C# type, fast and flexible | Not a Json Schema, but a Json DOM container for the schema |
| String | Native C# type | Not a Json Schema or Json DOM, very poor type hinting |

Expand Down
14 changes: 7 additions & 7 deletions docs/decisions/0042-samples-restructure.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
# Reestructure of How Sample Code will be Structured In the Repository
# Restructure of How Sample Code will be Structured In the Repository

status: accepted
contact: rogerbarreto
Expand Down Expand Up @@ -228,7 +228,7 @@ Identified Component Oriented Concepts:

- Planners

- Handlerbars
- Handlebars

- Authentication

Expand Down Expand Up @@ -358,7 +358,7 @@ Concepts/
│ ├── Resiliency/
│ └── Usage/
├── Planners/
│ └── Handlerbars/
│ └── Handlebars/
├── Authentication/
│ └── Azure AD/
├── Function Calling/
Expand Down Expand Up @@ -420,7 +420,7 @@ Concepts/
│ ├── Resiliency/
│ └── Usage/
├── Planners/
│ └── Handlerbars/
│ └── Handlebars/
├── Authentication/
│ └── Azure AD/
├── Function Calling/
Expand Down Expand Up @@ -502,7 +502,7 @@ Concepts/
├── DependencyInjection
├── HttpClient.Resiliency
├── HttpClient.Usage
├── Planners.Handlerbars
├── Planners.Handlebars
├── Authentication.AzureAD
├── FunctionCalling.AutoFunctionCalling
├── FunctionCalling.ManualFunctionCalling
Expand Down Expand Up @@ -545,7 +545,7 @@ Concepts/
├── Logging
├── DependencyInjection
├── HttpClient
├── Planners.Handlerbars
├── Planners.Handlebars
├── Authentication.AzureAD
├── FunctionCalling
├── Filtering
Expand Down Expand Up @@ -634,7 +634,7 @@ Concepts/

Pros:

- Beginers will be oriented to the right difficulty level and examples will be more organized by complexity
- Beginners will be oriented to the right difficulty level and examples will be more organized by complexity

Cons:

Expand Down
2 changes: 1 addition & 1 deletion docs/decisions/0072-agents-with-memory.md
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ await ragStore.UpsertDocumentsAsync(
var agentThread = new ChatHistoryAgentThread();
agentThread.ThreadExtensionsManager.RegisterThreadExtension(ragComponent);

// Inovke the agent.
// Invoke the agent.
var asyncResults1 = agent.InvokeAsync("What was the income of Contoso for 2023", agentThread);
// Expected response contains the 174M income from the document.
```
Expand Down
2 changes: 1 addition & 1 deletion dotnet/samples/Concepts/Agents/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Prefix|Description
---|---
OpenAIAssistant|How to use agents based on the [Open AI Assistant API](https://platform.openai.com/docs/assistants).
MixedChat|How to combine different agent types.
ComplexChat|How to deveop complex agent chat solutions.
ComplexChat|How to develop complex agent chat solutions.
Legacy|How to use the legacy _Experimental Agent API_.

## Legacy Agents
Expand Down
2 changes: 1 addition & 1 deletion dotnet/samples/Concepts/Functions/MethodFunctions_Types.cs
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ public async Task<string> TaskInjectingCultureInfoOrIFormatProviderWithStringRes
[KernelFunction]
public async Task<string> TaskInjectingCancellationTokenWithStringResult(CancellationToken cancellationToken)
{
var result = $"Cancellation resquested: {cancellationToken.IsCancellationRequested}";
var result = $"Cancellation requested: {cancellationToken.IsCancellationRequested}";
this._output.WriteLine($"Running {nameof(this.TaskInjectingCultureInfoOrIFormatProviderWithStringResult)} -> Injected Cancellation Token -> result: {result}");
return result;
}
Expand Down
2 changes: 1 addition & 1 deletion dotnet/samples/Concepts/Memory/TextChunkingAndEmbedding.cs
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ private async Task RunExampleAsync()
Jane: Darn, it's just repeating stuff now.
John: I think we're done.
Jane: We're not though! We need like 1500 more characters.
John: Oh Cananda, our home and native land.
John: Oh Canada, our home and native land.
Jane: True patriot love in all thy sons command.
John: With glowing hearts we see thee rise.
Jane: The True North strong and free.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public class ConversationSummaryPlugin(ITestOutputHelper output) : BaseTest(outp
Jane: Darn, it's just repeating stuff now.
John: I think we're done.
Jane: We're not though! We need like 1500 more characters.
John: Oh Cananda, our home and native land.
John: Oh Canada, our home and native land.
Jane: True patriot love in all thy sons command.
John: With glowing hearts we see thee rise.
Jane: The True North strong and free.
Expand Down
2 changes: 1 addition & 1 deletion dotnet/samples/Concepts/Plugins/ImportPluginFromGrpc.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace Plugins;
// This example shows how to use gRPC plugins.
public class ImportPluginFromGrpc(ITestOutputHelper output) : BaseTest(output)
{
[Fact(Skip = "Setup crendentials")]
[Fact(Skip = "Setup credentials")]
public async Task RunAsync()
{
Kernel kernel = new();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ namespace ProcessFramework.Aspire.SignalR.ProcessOrchestrator.Steps;
public class GenerateDocumentationStep : KernelProcessStep<GenerateDocumentationState>
{
/// <summary>
/// Function names of the steps, to be refereced when hooking up the step in a SK process
/// Function names of the steps, to be referenced when hooking up the step in a SK process
/// </summary>
public static class ProcessFunctions
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ namespace ProcessWithCloudEvents.Processes.Steps;
public class GenerateDocumentationStep : KernelProcessStep<GenerateDocumentationState>
{
/// <summary>
/// Function names of the steps, to be refereced when hooking up the step in a SK process
/// Function names of the steps, to be referenced when hooking up the step in a SK process
/// </summary>
public static class ProcessFunctions
{
Expand Down
2 changes: 1 addition & 1 deletion dotnet/src/Agents/Abstractions/Agent.cs
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ protected virtual async Task<TThreadType> EnsureThreadExistsWithMessagesAsync<TT
}

/// <summary>
/// Notfiy the given thread that a new message is available.
/// Notify the given thread that a new message is available.
/// </summary>
/// <remarks>
/// <para>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
namespace Microsoft.SemanticKernel.Agents.OpenAI;

/// <summary>
/// Extensons methods for <see cref="KernelContent"/>.
/// Extension methods for <see cref="KernelContent"/>.
/// </summary>
internal static class KernelContentExtensions
{
Expand Down
8 changes: 4 additions & 4 deletions dotnet/src/Agents/UnitTests/Internal/KeyEncoderTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,16 @@ public class KeyEncoderTests
public void VerifyKeyEncoderUniqueness()
{
// Act
this.VerifyHashEquivalancy([]);
this.VerifyHashEquivalancy(nameof(KeyEncoderTests));
this.VerifyHashEquivalancy(nameof(KeyEncoderTests), "http://localhost", "zoo");
this.VerifyHashEquivalency([]);
this.VerifyHashEquivalency(nameof(KeyEncoderTests));
this.VerifyHashEquivalency(nameof(KeyEncoderTests), "http://localhost", "zoo");

// Assert: Verify "well-known" value
string localHash = KeyEncoder.GenerateHash([typeof(ChatHistoryChannel).FullName!]);
Assert.Equal("Vdx37EnWT9BS+kkCkEgFCg9uHvHNw1+hXMA4sgNMKs4=", localHash);
}

private void VerifyHashEquivalancy(params string[] keys)
private void VerifyHashEquivalency(params string[] keys)
{
// Act
string hash1 = KeyEncoder.GenerateHash(keys);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
namespace Microsoft.SemanticKernel.Connectors.Amazon.UnitTests;

/// <summary>
/// Unit tests for prompt execution settings confirgurations for different Bedrock Models.
/// Unit tests for prompt execution settings configurations for different Bedrock Models.
/// </summary>
public class BedrockChatCompletionModelExecutionSettingsTests
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ template: |
If there is not a fitting function available to validate the result, I can provide the final answer in a clear and human-readable format.
[END THOUGHT PROCESS]

IMOPRTANT REMINDER: your each response should contain only one next step and only single one $JSON_BLOB. Do not provide more than one step.
IMPORTANT REMINDER: each response should contain only one next step and only a single $JSON_BLOB. Do not provide more than one step.
Let's break down the problem step by step and think about the best approach.

Begin!
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public sealed class MessageSourceBuilder
/// <summary>
/// Initializes a new instance of the <see cref="MessageSourceBuilder"/> class.
/// </summary>
/// <param name="messageType">The meassage type</param>
/// <param name="messageType">The message type</param>
/// <param name="source">The source step builder</param>
/// <param name="condition">Condition that must be met for the message to be processed</param>
public MessageSourceBuilder(string messageType, ProcessStepBuilder source, KernelProcessEdgeCondition? condition = null)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Microsoft.SemanticKernel;

/// <summary>
/// A class to describe the content schma of a response/return type from an KernelFunctionFactory, in a JSON Schema friendly way.
/// A class to describe the content schema of a response/return type from a KernelFunctionFactory, in a JSON Schema friendly way.
/// </summary>
internal sealed class JsonSchemaResponse
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ private async Task UpdateWhiteboardAsync(ChatMessage newMessage, CancellationTok
var inputMessagesJson = JsonSerializer.Serialize(basicMessages, WhiteboardProviderSourceGenerationContext.Default.IEnumerableBasicMessage);
var currentWhiteboardJson = JsonSerializer.Serialize(this._currentWhiteboardContent, WhiteboardProviderSourceGenerationContext.Default.ListString);

// Inovke the LLM to extract the latest information from the input messages and update the whiteboard.
// Invoke the LLM to extract the latest information from the input messages and update the whiteboard.
var result = await this._chatClient.GetResponseAsync(
this.FormatPromptTemplate(inputMessagesJson, currentWhiteboardJson, this._maxWhiteboardMessages),
new()
Expand Down
2 changes: 1 addition & 1 deletion python/samples/getting_started_with_agents/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Example|Description
[step08_chat_completion_agent_json_result](../getting_started_with_agents/chat_completion/step08_chat_completion_agent_json_result.py)|How to have an agent produce JSON.
[step09_chat_completion_agent_logging](../getting_started_with_agents/chat_completion/step09_chat_completion_agent_logging.py)|How to enable logging for agents.
[step10_chat_completion_agent_structured_outputs](../getting_started_with_agents/chat_completion/step10_chat_completion_agent_structured_outputs.py)|How to use have a chat completion agent use structured outputs
[step11_chat_completion_agent_declarative](../getting_started_with_agents/chat_completion/step11_chat_completion_agent_declarative.py)|How to create a chat compltion agent from a declarative spec.
[step11_chat_completion_agent_declarative](../getting_started_with_agents/chat_completion/step11_chat_completion_agent_declarative.py)|How to create a chat completion agent from a declarative spec.

## Azure AI Agent

Expand Down