-
Notifications
You must be signed in to change notification settings - Fork 1k
Transition documentation from Office UI Fabric to Fluent UI #10470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updated documentation to reflect the transition from Office UI Fabric to Fluent UI, including changes to project setup and component usage.
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit cb1adbb: 💡 Validation status: suggestions
docs/spfx/web-parts/get-started/use-fabric-react-components.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
andrewconnell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current state of OUIF & Fluent UI in SPFx trips me up... I think the changes here are correct, but...
@StfBauer, are you aware if these changes are correct & current for current GA SPFx?
I appreciate that someone took the time to update the code in the documentation. The suggested changes do not bring any new value to the documentation. Sure, the sample code has changed between SPFx releases, but in essence, the documentation is the same as it ever was. When you created the Minimal template, you didn't even include the code mentioned in the PR. |
|
The 'value' would be that your documentation would be correct, and the code would actually work. Though going by the state of the rest of the documentation it's possible that not much value is associated with that. |
|
Sorry for the delay in following up on this thread... no excuses, just swamped & I lost track of it. #mybad @Neutrino-Sunset said:
Ouch... we appreciate the contrib... this is a huge repo, lots of old docs, and always working to improve them. The punchy comment isn't necessary. I asked @StfBauer to take a look at the submission as he's more knowledgeable on the current state of this topic in SPFx. I didn't want to just accept & merge/close or leave it hanging. I'm trying to make sure I understand the changes you submitted, and if they reflect the official state of the current version of SPFx. @StfBauer said:
I can't tell from your response if you're saying if the changes are or are not a correct reflection of the current state of SPFx. Can you clarify your comments? |
|
@andrewconnell, I would add a general warning to this document and keep it as is. Office UI Fabric was deprecated in 2020, almost 6 years ago. If someone would still use this or come to this page, it isn't very certain. The permalink still would reference "fabric". If such documentation is required, it should come from Microsoft officially. Once Fluent UI 9 is ready to use in SPFx, the document is outdated again. Which hopefully happens sooner or later this year. |
Updated documentation to reflect the transition from Office UI Fabric to Fluent UI, including changes to project setup and component usage.
Category
Related issues
What's in this Pull Request?
Updated documentation to reflect the transition from Office UI Fabric to Fluent UI.
Updated sample code that no longer works.