Skip to content

Conversation

@Neutrino-Sunset
Copy link

Updated documentation to reflect the transition from Office UI Fabric to Fluent UI, including changes to project setup and component usage.

Category

  • [ x] Content fix
  • New article

Related issues

  • fixes #issuenumber
  • partially #issuenumber
  • mentioned in #issuenumber

What's in this Pull Request?

Updated documentation to reflect the transition from Office UI Fabric to Fluent UI.
Updated sample code that no longer works.

Updated documentation to reflect the transition from Office UI Fabric to Fluent UI, including changes to project setup and component usage.
@learn-build-service-prod
Copy link
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit cb1adbb:

💡 Validation status: suggestions

File Status Preview URL Details
docs/spfx/web-parts/get-started/use-fabric-react-components.md 💡Suggestion View Details

docs/spfx/web-parts/get-started/use-fabric-react-components.md

  • Line 27, Column 3: [Suggestion: learn-site-link-broken - See documentation] Link '/javascript/api/office-ui-fabric-react' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@andrewconnell andrewconnell self-assigned this Nov 12, 2025
@andrewconnell andrewconnell added the pr:in-review Actively reviewing pull request label Nov 12, 2025
@andrewconnell andrewconnell self-requested a review November 12, 2025 14:48
Copy link
Collaborator

@andrewconnell andrewconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current state of OUIF & Fluent UI in SPFx trips me up... I think the changes here are correct, but...

@StfBauer, are you aware if these changes are correct & current for current GA SPFx?

@andrewconnell andrewconnell added the pr:do-not-merge Pull request not ready to be merged label Nov 26, 2025
@StfBauer
Copy link
Collaborator

StfBauer commented Dec 1, 2025

The current state of OUIF & Fluent UI in SPFx trips me up... I think the changes here are correct, but...

@StfBauer, are you aware if these changes are correct & current for the current GA SPFx?

I appreciate that someone took the time to update the code in the documentation.

The suggested changes do not bring any new value to the documentation. Sure, the sample code has changed between SPFx releases, but in essence, the documentation is the same as it ever was.

When you created the Minimal template, you didn't even include the code mentioned in the PR.

@Neutrino-Sunset
Copy link
Author

The 'value' would be that your documentation would be correct, and the code would actually work.

Though going by the state of the rest of the documentation it's possible that not much value is associated with that.

@andrewconnell
Copy link
Collaborator

Sorry for the delay in following up on this thread... no excuses, just swamped & I lost track of it. #mybad

@Neutrino-Sunset said:

Though going by the state of the rest of the documentation it's possible that not much value is associated with that.

Ouch... we appreciate the contrib... this is a huge repo, lots of old docs, and always working to improve them. The punchy comment isn't necessary.

I asked @StfBauer to take a look at the submission as he's more knowledgeable on the current state of this topic in SPFx. I didn't want to just accept & merge/close or leave it hanging. I'm trying to make sure I understand the changes you submitted, and if they reflect the official state of the current version of SPFx.

@StfBauer said:

Sure, the sample code has changed between SPFx releases, but in essence, the documentation is the same as it ever was.

When you created the Minimal template, you didn't even include the code mentioned in the PR.

I can't tell from your response if you're saying if the changes are or are not a correct reflection of the current state of SPFx. Can you clarify your comments?

@StfBauer
Copy link
Collaborator

@andrewconnell, I would add a general warning to this document and keep it as is. Office UI Fabric was deprecated in 2020, almost 6 years ago.

If someone would still use this or come to this page, it isn't very certain.

The permalink still would reference "fabric". If such documentation is required, it should come from Microsoft officially.

Once Fluent UI 9 is ready to use in SPFx, the document is outdated again. Which hopefully happens sooner or later this year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:do-not-merge Pull request not ready to be merged pr:in-review Actively reviewing pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants