Update Whois to remove the leading space in front of email #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelming
reviewed
Nov 27, 2024
Collaborator
chelming
left a comment
chelming
left a comment
There was a problem hiding this comment.
you could do it all in one line with
message_body = message_body.replace(/^\s*/gm,'').match(/^(real_name|tz_label|email):.*$/gm).join('\n');if any other fields get added we wouldn't have to worry about leading spaces then 🤷
or just change the replace line in yours to .replace(/^\s*/gm,'')
wiz0floyd
reviewed
Dec 17, 2024
| } | ||
|
|
||
| message_body = message_body.match(/^(real_name|tz_label| {2}email):.*$/gm).join('\n'); | ||
| message_body = message_body.replace(/^\s{2}(email)/gm, '$1'); |
Collaborator
There was a problem hiding this comment.
You could trim before joining in case we ever have other indented lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.