fix: persist cleaned epoch transition state before ack#270
Open
matthias-wright wants to merge 3 commits into
Open
fix: persist cleaned epoch transition state before ack#270matthias-wright wants to merge 3 commits into
matthias-wright wants to merge 3 commits into
Conversation
|
This fixes the main #246 persistence issue: transition deltas are cleared before the next-epoch consensus state is stored and committed. One follow-up concern: the finalized-block ack now happens after the oracle/orchestrator epoch-transition reports as well as after DB commit. Is that intended? If oracle/orchestrator reporting can block, this moves external backpressure onto the finalized-block ack path even after durable persistence has succeeded. |
5fbd10e to
789a355
Compare
Collaborator
Author
|
Update(7077fd6):
|
7077fd6 to
886a983
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: #246 and #325
Changes
added_validators/removed_validatorsbefore storing next-epoch consensus state.Note: once this and #382 are on the same base, we should add a finalizer test that injects a commit failure at an epoch boundary and asserts the syncer ack is withheld (the Exact waiter resolves Err/canceled) and the node shuts down without durably advancing the epoch.