drm/rockchip: retrigger RK3588 DP hotplug after connector settle#1
Open
weicheng04 wants to merge 1 commit into
Open
drm/rockchip: retrigger RK3588 DP hotplug after connector settle#1weicheng04 wants to merge 1 commit into
weicheng04 wants to merge 1 commit into
Conversation
Late DP hotplug on RK3588 can leave userspace with a connected connector and readable EDID, but without an enabled CRTC if the first modeset happens before the DP/Type-C path has fully settled. Add a RK3588-only delayed hotplug retrigger for long HPD plug events. The delayed work rechecks connector presence and then emits a connector hotplug event so userspace gets a clean modeset retry after the link has settled. Do not reset or reinitialize the DP controller in this path, since that was observed to make subsequent AUX/DPCD transfers time out on RK3588. Signed-off-by: weicheng04 <weicheng.xiao@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes RK3588 DisplayPort hotplug handling in
dw-dp.c.Changes:
Why
On RK3588, a late DP hotplug can happen while the Type-C/DP path is still settling. In that case the connector may become
connectedand EDID can be readable, but userspace may not complete asuccessful modeset, leaving the DP output disabled.
Observed failure state:
card0-DP-1reportsconnectedThis patch avoids resetting or reinitializing the DP controller in the HPD path, because controller reset was observed to cause AUX/DPCD timeouts on RK3588. Instead, it schedules a delayed
connector hotplug event after the link has had time to settle.
The change is limited to
RK3588_DP, so other DW-DP users are not affected.Testing
Tested on reComputer RK3588 devkit with DP hotplug after boot.
Verified:
connectedenabledExpected kernel log includes: