feat: adopt Tailwind CSS utility classes for styling - #6
Draft
nicomiguelino wants to merge 1 commit into
Draft
Conversation
Rework index.html to use Tailwind utility classes instead of custom CSS classes, keeping visual appearance and behavior unchanged. Slim the CSS entry point down to just the design-system import. Bump @screenly/edge-apps to ^1.3.0 for upcoming Tailwind CSS support. No screenshots/* included: this app never had e2e/screenshots.spec.ts wired up (bun run screenshots fails with "No tests found" even on main), so there was nothing to regenerate. Manually verified the app's own chrome (background, error screen) renders pixel-identical to before via an ad hoc Playwright check against the built preview.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index.htmlto use Tailwind utility classes (arbitrary-value bracket syntax for exact px/rem/color values) instead of custom CSS classes, keeping visual appearance and behavior unchanged.src/css/style.cssdown to just the design-system import (@layer theme, base, utilities;+ the three@imports), per the standard pattern.@screenly/edge-appsto^1.3.0(unpublished; ships Tailwind support)..tradingview-widget-container/.tradingview-widget-container__widgetclass names on the widget root (TradingView's own embed convention, targeted by their injected script/CSS) are left untouched verbatim; onlyw-full h-fullutilities were added alongside them for sizing, which this app's own CSS previously provided.Reference PRs used as the pattern for this migration:
Test plan
bun run type-check— passesbun test src/ --path-ignore-patterns='**/*.live.test.ts'— 22 pass / 0 fail (no test asserts on CSS class names, only on element IDs and inlinestyle.display, so nothing needed updating)bun run build— succeeds (pre-existingimport.meta/iife warnings from@screenly/edge-appsdev-tools are unrelated to this change)bun run screenshots— this repo has never hade2e/screenshots.spec.tswired up (unlike clock-app/weather-app), so the script fails with "No tests found" even onmain/developmentbefore this change. This is a pre-existing gap, out of scope for this PR.vite preview, and used an ad hoc Playwright script (mockingscreenly.jsthe same way the library's screenshot helpers do) to confirm the app's own chrome renders correctly — full-bleed dark (#131722) background behind the TradingView widget, and the error-screen card (with the exact same gap/padding/typography as before) when forcibly triggered. The embedded TradingView chart itself rendered live and correctly in this sandbox (network access was available), confirming the widget container sizing utilities work as expected.Notes
developmentandorigin/mainhad diverged (development is missing main's icon-update commits Add App Icon #3; main is missing development's@screenly/edge-appsbump commit chore(deps): bump @screenly/edge-apps to 1.2.1 #4). A fast-forward merge wasn't possible, so per migration instructions I left that divergence alone and based this branch ondevelopmentas-is, rather than forcing a merge.