Repository navigation
chore: adopt signage-kit 2026.10.0 - #29
Merged
Merged
Conversation
Picks up the capability-probe fix. `./capability` decided whether an engine was stale by reading `Element.prototype.replaceChildren`, which `./polyfills` — imported as the first line of this app's browser entry — had already installed. So `old` could never fire, and `player_degraded_reason` could only ever report `none`, `slow` or `probe-failed`. Rendering was never affected: the inline gate runs in <head>, ahead of the bundle, and still saw the engine's own `replaceChildren`. This is a telemetry fix and needs no code change here. Also picks up the page-view attribution fix that has been in 2026.8.11 since August. Pin 2026.8.10 -> 2026.10.0. Lockfile updated with bun; lint and tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the pin
2026.8.10→2026.10.0.The release fixes the degraded-path probe:
./capabilitydecided whether an engine was stale by readingElement.prototype.replaceChildren, which./polyfills— imported as the first line of this app's browser entry, by design — had already installed. Sooldcould never fire andplayer_degraded_reasoncould only ever reportnone,sloworprobe-failed.Rendering was never affected. The inline gate runs in
<head>, ahead of the bundle, so it always saw the engine's ownreplaceChildrenand screens have always been on the correct path. This is a telemetry fix and needs no code change in this app.Also picks up the page-view attribution fix that has been in 2026.8.11 since August.
Release notes: https://github.com/Screenly-Labs/signage-kit/releases/tag/2026.10.0
Verified locally with what CI runs:
bun install --frozen-lockfile,bun run lint,bun test— all clean, and the installed kit resolves to 2026.10.0.🤖 Generated with Claude Code