Correct the deploy docs and drop the remaining em dashes - #15
Open
vpetersson-bot wants to merge 1 commit into
Open
Correct the deploy docs and drop the remaining em dashes#15vpetersson-bot wants to merge 1 commit into
vpetersson-bot wants to merge 1 commit into
Conversation
Two doc/copy cleanups, no behaviour change. CLAUDE.md and README.md both claimed a push to master deploys to Pages. It does not: deploy-pages.yml triggers on a CalVer tag (or a manual workflow_dispatch), so master on its own ships nothing. Both now say so. Also removes the remaining em dashes (27 across CLAUDE.md, README.md, the two TS entry points, tailwind.css, build.js and sync-fonts.js), rewriting each to a colon, semicolon, comma or parenthetical as the sentence needs rather than swapping the character blindly. The manifest and meta description were already done in Screenly-Labs#14. typecheck, lint, test (28 pass) and build all clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #14, which fixed only the manifest and meta description because those were the strings leaking onto signage-apps.com. This closes out the rest. No behaviour change.
The deploy docs were wrong
CLAUDE.mdandREADME.mdboth said a push tomasterdeploys to Pages:That is not what the workflow does.
deploy-pages.ymltriggers on a CalVer tag push ([0-9][0-9][0-9][0-9].*) or a manualworkflow_dispatch; a push tomasteron its own ships nothing. Confirmed in practice this release: merging #14 to master triggered no deploy, and only pushing2026.8.0published it.Both files now describe the tag trigger, and say plainly that
masteralone does not deploy.Remaining em dashes
27 of them, across
CLAUDE.md,README.md,assets/static/js/main.ts,assets/static/js/timer.ts,assets/static/styles/tailwind.css,build.jsandsync-fonts.js.Each was rewritten to whatever the sentence actually wanted, a colon, semicolon, comma or parenthetical, rather than swapping the character blindly:
**Direction is automatic** — a future target counts down→…automatic**: a future target…counting down to — or up from —→counting down to, or up from,Returns nothing — it's called on a→Returns nothing; it's called on a## Design — "Countdown"→## Design: "Countdown"Verification
bun run typecheck,bun run lint,bun test(28 pass) andbun run buildall clean. Zero em or en dashes left in any tracked file.