Run CI on release PRs into production - #31
Open
vpetersson wants to merge 1 commit into
Open
Conversation
A release PR (master -> production) is the last gate before a deploy users see, and it was the one PR that ran no checks: CI triggered only on pull_request into master/main. The failure mode is worse than a missing signal. GitHub still shows a green "Deploy" status on such a PR — the stage deploy from the earlier master merge, attached to the same head commit — which reads as CI having passed when lint and tests never ran. That is exactly how #30 looked when it was merged to production. The code in #30 was in fact covered: its tree hashed identical to the tree CI passed on in #29, so nothing shipped untested. But that took a manual tree comparison to establish, which is not a check. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A release PR (
master→production) is the last gate before a deploy users see, and it was the one PR that ran no checks — CI triggered only onpull_requestintomaster/main.The failure mode is worse than a missing signal. GitHub still shows a green Deploy status on such a PR (the stage deploy from the earlier master merge, attached to the same head commit), which reads as CI having passed when lint and tests never ran. That is exactly how #30 looked when it was merged to production.
For the record, #30 was covered — its tree hashed identical (
17d5cc47…) to the tree CI passed on in #29, so nothing shipped untested. But establishing that took a manualgit rev-parse ^{tree}comparison, which is not a check.Change
Verification
This PR targets
master, so it cannot exercise the new trigger on itself — theproductionentry only takes effect once merged, on the next release PR. What it does prove is that the workflow still parses and the existing trigger is intact:yaml.safe_load→branches: ['master', 'main', 'production'], joblint-and-testintact.mastertrigger still fires.🤖 Generated with Claude Code