7zip-dark: Add version 26.01-v0.61.0#2779
Conversation
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with 7zip-dark
|
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a new static bucket manifest Changes
Sequence Diagram(s)sequenceDiagram
participant Manifest as Installer (manifest)
participant GH as GitHub Releases
participant Base as 7-zip.org
participant FS as File System
participant Reg as Registry Scripts
Manifest->>GH: download Dark7zip ZIP (contains patch.dl)
Manifest->>Base: download base 7-Zip artifact (MSI/7zr/7z.exe)
GH->>FS: provide patch.dl inside ZIP
Base->>FS: provide base EXE/MSI
Manifest->>FS: extract base EXE and patch.dl
Manifest->>FS: run 7z.exe to apply patch.dl into install root
Manifest->>FS: remove temporary artifacts (patch.dl, temp EXEs)
Manifest->>Reg: read script templates, substitute install root (and HKLM if $global)
Manifest->>FS: write updated reg files as ASCII and create shortcut/binaries
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 6 minutes and 30 seconds.Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/7zip-dark.json`:
- Line 42: The Remove-Item command string "Remove-Item \"$dir\\Uninstall.exe\",
\"$dir\\7z2600-arm64.exe\", \"$dir\\patch.dl\", $7zr -Force" can fail if files
are missing; make cleanup tolerant by adding -ErrorAction SilentlyContinue to
the Remove-Item invocation or wrap each path with a Test-Path guard before
removal so missing artifacts don't cause the installer to fail; update the
command string in the JSON entry accordingly.
- Around line 29-42: The pre_install step currently downloads and runs an
unchecked 7zr.exe (see $7zr, Join-Path, Invoke-WebRequest) which bypasses
manifest hashing; instead add the 7zr.exe asset to the manifest's "url" and add
its SHA256 to the "hash" array so the installer fetches a pinned, verified
binary, then remove the Invoke-WebRequest line and modify pre_install to
reference the already-declared asset path ($7zr or the asset filename in $dir)
so Invoke-ExternalCommand runs only the manifest-verified 7zr.exe.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4c8848eb-f2ff-4144-be56-86374dfb8ea2
📒 Files selected for processing (1)
bucket/7zip-dark.json
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with 7zip-dark
|
|
This is a known longstanding issue. The servers at |
Updated version and license information, modified URLs for downloads, and adjusted pre-install and post-install scripts.
|
/verify |
|
All changes look good. Wait for review from human collaborators. 7zip-dark
|
This PR adds a new manifest for 7-Zip-Dark, a patched version of 7-Zip that supports native Dark Mode.
Relates to main/7zip
7zip-dark@26.00-v0.48.0: initial releaseSummary by CodeRabbit