Open
Conversation
af89ee9 to
4527a82
Compare
Soulou
reviewed
Jul 17, 2023
Member
Soulou
left a comment
There was a problem hiding this comment.
The code looks great, it's tricky to validate if it works correctly because of the lack of tests.
What do you think about using this PR to introduce some testing in the buildpack to prevent regressions?
Or maybe merge it and then prepare another PR with the ability to test the behavior?
What do you think would be best?
Contributor
Author
|
I'd be keen to:
WDYT? |
Member
|
@Frzk Look good to me, but do you prefer this PR being merged or wait later? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a complete rewrite of
lib/peclwhich originally contains code to install any PECL extension.While trying to reproduce #236, I dove into this code and thought it would greatly benefit from a rewrite. So, this PR:
set +ethat was put at some point,oci8,yamlandscoutapm). This part is maybe the most arguable (see thephp::pecl::enable_pecl_extensionandphp::pecl::configure_extensionfunctions).Fixes #236