Conversation
There was a problem hiding this comment.
Pull request overview
Fixes version detection logic in dists/install.sh so the installer can correctly read the currently installed CLI version and prompt for replacement, and documents the fix in the changelog.
Changes:
- Adjusted
--versionparsing indists/install.shfrom field 4 to field 3. - Added a “To Be Released” changelog entry describing the fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dists/install.sh | Corrects how the installer extracts the CLI version from scalingo --version. |
| CHANGELOG.md | Adds a release note for the install script fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| new_version=$($exe_path --version | cut -d' ' -f3) | ||
| old_version=$("$target" --version | cut -d' ' -f3) |
There was a problem hiding this comment.
cut -d' ' -f3 is still quite brittle because it assumes the version will always be the 3rd whitespace-delimited token. Since --version output formatting can change (extra words, different binary name, etc.), consider extracting the last token instead (e.g., via awk '{print $NF}') or a simple semver regex, to make version detection more robust.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
QA not using the script but the bash commands.
Fix #1183.