Skip to content

Fix install.sh script#1184

Merged
matthieu526-scalingo merged 2 commits intomasterfrom
fix/1183/fix-install-script
Feb 10, 2026
Merged

Fix install.sh script#1184
matthieu526-scalingo merged 2 commits intomasterfrom
fix/1183/fix-install-script

Conversation

@matthieu526-scalingo
Copy link
Contributor

QA not using the script but the bash commands.

➜  cli git:(fix/1183/fix-install-script) old_version=$(scalingo --version | cut -d' ' -f3)
➜  cli git:(fix/1183/fix-install-script) ✗ echo $old_version                                
1.43.0
  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

Fix #1183.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes version detection logic in dists/install.sh so the installer can correctly read the currently installed CLI version and prompt for replacement, and documents the fix in the changelog.

Changes:

  • Adjusted --version parsing in dists/install.sh from field 4 to field 3.
  • Added a “To Be Released” changelog entry describing the fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
dists/install.sh Corrects how the installer extracts the CLI version from scalingo --version.
CHANGELOG.md Adds a release note for the install script fix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +181 to +182
new_version=$($exe_path --version | cut -d' ' -f3)
old_version=$("$target" --version | cut -d' ' -f3)
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cut -d' ' -f3 is still quite brittle because it assumes the version will always be the 3rd whitespace-delimited token. Since --version output formatting can change (extra words, different binary name, etc.), consider extracting the last token instead (e.g., via awk '{print $NF}') or a simple semver regex, to make version detection more robust.

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@matthieu526-scalingo matthieu526-scalingo merged commit f63f523 into master Feb 10, 2026
7 checks passed
@matthieu526-scalingo matthieu526-scalingo deleted the fix/1183/fix-install-script branch February 10, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix install.sh script since move to urfave/cli v3

2 participants