Skip to content

Send data mask from theory calculator into plotter#665

Draft
pkienzle wants to merge 6 commits intomasterfrom
fix-bumps-qrange-support
Draft

Send data mask from theory calculator into plotter#665
pkienzle wants to merge 6 commits intomasterfrom
fix-bumps-qrange-support

Conversation

@pkienzle
Copy link
Contributor

@pkienzle pkienzle commented Aug 21, 2025

From @butlerpd

So we got this email on the help desk about the script for fitting data to the guinier_porod model with bumps was not working because bumps is not honoring the qmin (but does honor qmax). James Crake-Merani (ISIS intern) tried it and agrees with me that it should work but says it does not. He also tried doing the mask differently per Wojciech’s suggestion which also did not work.

This PR lets me fit a dataset with qmin and qmax specified using bumps.

To test, uncomment the following:

#datasets[1].qmin, datasets[1].qmax = 1e-4, 4e-3

and run it in bumps:

bumps example/simul_fit.py -s

To test 2D data masks, uncomment the following:

#radial_data.qmin, radial_data.qmax = 0.01, 0.02

and run it in bumps:

bumps example/fit.py -s

Copy link
Collaborator

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems reasonable. Haven't tested functionality

@pkienzle pkienzle marked this pull request as draft March 3, 2026 00:23
@pkienzle
Copy link
Contributor Author

pkienzle commented Mar 3, 2026

Converting to draft. This needs to be rebased on top of #676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants