Skip to content

ci: auto-upload to Launchpad PPA on tag - #547

Merged
Sapd merged 1 commit into
masterfrom
ci/auto-ppa-upload
Jul 23, 2026
Merged

ci: auto-upload to Launchpad PPA on tag#547
Sapd merged 1 commit into
masterfrom
ci/auto-ppa-upload

Conversation

@Sapd

@Sapd Sapd commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Codifies the manual debuild -Sdebsigndput flow into CI.

On a semver tag it builds the Debian source package (version derived from the tag, ~<series>1 suffix), signs with the release subkey, and dputs to ppa:sapd/headsetcontrol. Launchpad then builds the .deb.

Reuses existing secrets GPG_PRIVATE_KEY/GPG_PASSPHRASE (no new secret needed) — imported and preset into gpg-agent by keygrip so debsign runs non-interactively.

Notes:

  • Targets noble only — jammy's GCC 11 can't build the C++20 code (same reason we skipped epel-9). Add newer Ubuntu series to the matrix as they appear.
  • Needs the tag to include debian/ (merged after 4.0.0), so it applies from the next release onward. First validation is the next tag (or workflow_dispatch).

On a semver tag, build the Debian source package (version from the tag),
sign with the release subkey (GPG_PRIVATE_KEY/GPG_PASSPHRASE secrets via
agent passphrase preset) and dput to ppa:sapd/headsetcontrol. Targets
noble only (needs GCC 13+ for C++20).

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2545a42c2a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- name: Install packaging tools
run: |
sudo apt-get update -qq
sudo apt-get install -y -qq devscripts debhelper dput

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Install the package's declared build dependencies

debuild -S still invokes dpkg-buildpackage's default build-dependency check (-D, --check-builddeps ... default), but this install list omits the source package's required libhidapi-dev from debian/control. The existing Linux build workflows install that dependency explicitly. Consequently, a tag-triggered PPA job on a standard hosted runner will stop at dpkg-checkbuilddeps before producing the signed .changes file; install libhidapi-dev (and preferably all declared Build-Depends) before invoking debuild.

Useful? React with 👍 / 👎.

@claude

claude Bot commented Jul 23, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@Sapd
Sapd merged commit 3a57178 into master Jul 23, 2026
5 checks passed
@Sapd
Sapd deleted the ci/auto-ppa-upload branch July 23, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant