Implement wasi-nn using nntrainer - #471
Draft
kulcsaradam wants to merge 1 commit into
Draft
Conversation
Introduce nntrainer as a third party application but do not include it as a submodule. Change build files, implement functions required for wasi-nn functionality and add simple test for wasi-nn. Signed-off-by: Ádám László Kulcsár <kuladam@inf.u-szeged.hu>
Contributor
Author
|
The patch changes quite a bit about how files work, since wasi treats files and directories the same, I've merged the two classes. These changes could be done in a different patch if needed. |
Contributor
Author
|
The patch will be broken up into a series of smaller patches for manageability's sake. After those patches are merged I'll change the draft to be ready for review. |
Contributor
Author
|
In the meantime I would welcome input on the patch, especially on some aspects:
@ksh8281 I would really appreciate your feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce nntrainer as a third party application but do not include it as a submodule. Change build files, implement functions required for wasi-nn functionality and add simple test for wasi-nn.