Fixes #398: Apple Clang Optimization Breaking Bytecode Mapping - #469
Closed
M-SE0K wants to merge 3 commits into
Closed
Fixes #398: Apple Clang Optimization Breaking Bytecode Mapping #469M-SE0K wants to merge 3 commits into
M-SE0K wants to merge 3 commits into
Conversation
Signed-off-by: M-SE0K <seg082911@gmail.com>
Signed-off-by: M-SE0K <seg082911@gmail.com>
Signed-off-by: M-SE0K <seg082911@gmail.com>
Contributor
Author
|
Closed in favor of PR #472. Reopened in a new PR to fix a few test failures I initially missed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
| #398
When built on macOS (Apple Clang), the opcode labels of the computed goto interpreter are merged into a single address by tail merging.
ByteCode::opcode()performs a reverse address → opcode lookup throughm_addressToOpcodeTable, so once merging occurs, different opcodes end up sharing the same address, which corrupts this table and makes it return the wrong opcode.Fix
__asm__ volatilebarrier after each opcode label so that the labels are not merged even when their bodies are identical. (Since an extra label is introduced,-Wno-unused-labelis added as well.)MoveFloatand others for the same purpose, restoring src/dst to their original order.m_addressToOpcodeTable.size() == OpcodeKindEndat initialization time so that any recurrence of the merging is detected immediately.Benchmark Results
aarch64 macOS,
test/wasmBenchmarker, average of 10 runs for each of 31 benchmarks (unit: seconds)tools/run-tests.py