fix: settle orphaned evaluating interjections - #974
Merged
SamSaffron merged 1 commit intoJul 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Settle locally persisted interjection messages that remain
evaluatingafter authoritative session state is idle and no live client transaction still owns them.evaluatingmessages transition tofailedWhy
An interjection is first rendered optimistically and persisted as a client-owned transcript intent. Its in-memory
pendingInterruptCommitsbookkeeping is not persisted. After a reload or interrupted recovery, the message can therefore survive forever asevaluatingeven though:active_run: falsepending_interjectionObserved on session 3137: “this is taking forever” remained
evaluating…for three hours while the server was idle and later turns had completed.Invariant
An inline interjection may show
evaluatingonly while a matching local pending commit or pending interjection transaction exists. Idle reconciliation marks unowned evaluating intents failed rather than leaving an immortal spinner.Verification
node internal/serveui/static/app_stream_test.jsnode internal/serveui/static/app_sessions_test.jsgo test ./internal/serveui/...go build .