fix(mobile): restore scrolling in profile sheets - #1560
Open
eleboucher wants to merge 14 commits into
Open
Conversation
eleboucher
force-pushed
the
fix/mobile-message-options-sheet
branch
from
August 1, 2026 14:05
e5e67c4 to
647e0a6
Compare
nushea
approved these changes
Aug 1, 2026
eleboucher
force-pushed
the
fix/mobile-message-options-sheet
branch
from
August 1, 2026 14:10
647e0a6 to
99852f0
Compare
…nts (#1552) <!-- Please read https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before submitting your pull request --> ### Description <!-- Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Fixes # #### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Checklist: - [x] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings ### AI disclosure: - [ ] Partially AI assisted (clarify which code was AI assisted and briefly explain what it does). - [ ] Fully AI generated (explain what all the generated code does in moderate detail). <!-- Write any explanation required here, but do not generate the explanation using AI!! You must prove you understand what the code in this PR does. -->
eleboucher
force-pushed
the
fix/mobile-message-options-sheet
branch
from
August 1, 2026 14:48
99852f0 to
71db9fa
Compare
…decryption (#1555) ### Description messages in encrypted rooms didn't appear until you scrolled or refocused. getType() returns m.room.encrypted until decryption finishes, but the render filter listed 'm.room.message.encrypted', which isn't a real type. b1ac4a6 turned that filter into a hard drop, so undecrypted events got no row, and nothing re-ran the filter once they decrypted. also fixes messages that fail to decrypt showing nothing instead of the placeholder. based on refactor/matrix-event-type-constants, which kept the bogus string as ROOM_MESSAGE_DECRYPTED. nothing sets that type, so it's removed. Fixes #1553 Fixes #1508 #### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Checklist: - [x] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings ### AI disclosure: - [ ] Partially AI assisted (clarify which code was AI assisted and briefly explain what it does). - [ ] Fully AI generated (explain what all the generated code does in moderate detail). <!-- Write any explanation required here, but do not generate the explanation using AI!! You must prove you understand what the code in this PR does. -->
eleboucher
force-pushed
the
fix/mobile-message-options-sheet
branch
2 times, most recently
from
August 1, 2026 15:00
f620208 to
0867d94
Compare
eleboucher
force-pushed
the
fix/mobile-message-options-sheet
branch
from
August 1, 2026 15:00
0867d94 to
8901474
Compare
eleboucher
changed the title
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-1560-sable.raspy-dream-bb1d.workers.dev | 8901474 | pr-1560 |
Sat, 01 Aug 2026 15:03:20 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Type of change
Checklist:
AI disclosure: