Add optional label parameter for pkcs11 support#241
Add optional label parameter for pkcs11 support#241krishnavema wants to merge 1 commit intoSSSD:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces an optional label parameter to the add_cert and add_key methods in the smartcard utility, allowing for PKCS#11 object labeling. Feedback was provided to update the docstrings for these methods to accurately reflect the str | None type hint for the new parameter to ensure consistency with the function signatures.
| :param label: Label for the PKCS#11 object, defaults to None. | ||
| :type label: str, optional |
There was a problem hiding this comment.
The type hint for the label parameter is str | None, but the docstring specifies :type label: str. To ensure documentation accuracy and prevent potential confusion for developers using this method, the type in the docstring should match the type hint in the function signature.
| :param label: Label for the PKCS#11 object, defaults to None. | |
| :type label: str, optional | |
| :param label: Label for the PKCS#11 object, defaults to None. | |
| :type label: str | None, optional |
| :param label: Label for the PKCS#11 object, defaults to None. | ||
| :type label: str, optional |
There was a problem hiding this comment.
The type hint for the label parameter is str | None, but the docstring specifies :type label: str. To ensure documentation accuracy and prevent potential confusion for developers using this method, the type in the docstring should match the type hint in the function signature.
| :param label: Label for the PKCS#11 object, defaults to None. | |
| :type label: str, optional | |
| :param label: Label for the PKCS#11 object, defaults to None. | |
| :type label: str | None, optional |
1 participant
Pkcs11 soft ocsp tests